Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better defaults/validation for the configmap #71

Closed
dlorenc opened this issue May 7, 2021 · 0 comments · Fixed by #83
Closed

Better defaults/validation for the configmap #71

dlorenc opened this issue May 7, 2021 · 0 comments · Fixed by #83
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@dlorenc
Copy link
Contributor

dlorenc commented May 7, 2021

We should probably clean up the configmap code a bit, the defaults are set in yaml which means they get overwritten every time you deploy.

We can probably do this better with actual defaults, and maybe even use reflection!
@dlorenc dlorenc added the kind/feature Categorizes issue or PR as related to a new feature. label May 7, 2021
This was referenced May 7, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add defaults and validation to configmap priyawadhwa/chains
1 participant
@dlorenc