Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLSA v1 should be wrapped into intoto v1 statement #920

Open
chuangw6 opened this issue Sep 8, 2023 · 1 comment
Open

SLSA v1 should be wrapped into intoto v1 statement #920

chuangw6 opened this issue Sep 8, 2023 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@chuangw6
Copy link
Member

chuangw6 commented Sep 8, 2023

Expected Behavior

SLSA v1 predicate should be wrapped into intoto v1 statement

Actual Behavior

It's wrapped into intoto v0.1 statement

chains/pkg/chains/formats/slsa/v2alpha2/internal/pipelinerun/pipelinerun.go

Line 47 in 70c8c7d

Type: intoto.StatementInTotoV01,

Related

in-toto/in-toto-golang#265

It would be ideal if intoto defines the v1.0 statement type in intoto project and chains uses it for _type field.
@chuangw6 chuangw6 added the kind/bug Categorizes issue or PR as related to a bug. label Sep 8, 2023
@chuangw6
Copy link
Member Author

chuangw6 commented Sep 8, 2023

cc @chitrangpatel @wlynch @lcarva

@aaron-prindle aaron-prindle mentioned this issue Mar 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chuangw6