Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhooks support for Gitlab #42

Closed
mnuttall opened this issue Jun 4, 2019 · 2 comments
Closed

Webhooks support for Gitlab #42

mnuttall opened this issue Jun 4, 2019 · 2 comments
Labels
webhooks

Comments

@mnuttall
Copy link
Contributor

mnuttall commented Jun 4, 2019

Currently we can only create webhooks for GitHub. GitLab is a widely used alternative that we should support.

Note that Epic #40 would remove our use of the Knative GitHub Event Source. The implementation work under this epic needs to take that done, or planned, under 40 into account.
@mnuttall mnuttall mentioned this issue Jun 11, 2019
Closed
@a-roberts a-roberts assigned dibbles and unassigned dibbles Jan 23, 2020
@a-roberts
Copy link
Member

a-roberts commented Jan 23, 2020 •
edited

Oops - assigned @dibbles to this one 😄 an update on this is that the prototype issue is done and works well, merged it this morning #58 and changes here #434

Perhaps this epic can now be closed? What else needs to be done?

@dibbles
Copy link
Member

dibbles commented Jan 24, 2020

I believe this can be closed (so I'm closing it) - I think I have fully implemented everything required

@dibbles dibbles closed this as completed Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
webhooks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mnuttall @a-roberts @dibbles