Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

githubOwners not creating pipelinerun/taskrun when the owner creates a pull request from different branch #1571

Closed
VeereshAradhya opened this issue Apr 4, 2023 · 6 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@VeereshAradhya
Copy link

Expected Behavior

githubOwners should create pipelinerun/taskrun when the owner creates a pull request from a different branch

Actual Behavior

githubOwners not creating pipelinerun/taskrun when owner creates a pull request from different branch

Steps to Reproduce the Problem

  1. Create a new repository in github and do not add OWNERS file
  2. Create an eventlistener that uses github interceptor with githubOwners param
  3. Add webhook to the repository
  4. Create a pull request to main from different branch

Additional Info

  • Kubernetes version:

    Output of kubectl version:

    Client Version: v1.25.7
    Kustomize Version: v4.5.7
    Server Version: v1.24.11+af0420d
    
  • Tekton Pipeline version:

    Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

    tkn version                                                                                            ✔  10:57:12 AM 
    Client version: 0.30.0
    Pipeline version: v0.44.0
    Triggers version: v0.23.0
    Operator version: v0.65.1
    
@VeereshAradhya VeereshAradhya added the kind/bug Categorizes issue or PR as related to a bug. label Apr 4, 2023
@VeereshAradhya VeereshAradhya changed the title githubOwners not creating pipelinerun/taskrun when owner creates a pull request from different branch githubOwners not creating pipelinerun/taskrun when the owner creates a pull request from different branch Apr 4, 2023
@nagasree9
Copy link
Contributor

@VeereshAradhya Could you also share the values you have set for githubOwners param

@VeereshAradhya
Copy link
Author

VeereshAradhya commented Apr 4, 2023

- name: "githubOwners"
  value: 
       enabled: true
       checkType: none

@nagasree9
Copy link
Contributor

I would say set the checkType value to repoMembers and also passin the PersonalAccessToken to make api calls into the repository

@VeereshAradhya
Copy link
Author

Pipelinerun is getting created after setting checkType to repoMembers. So, the feature is working as expected. Shall I close the bug?

@savitaashture
Copy link
Contributor

@VeereshAradhya Yes you can close the bug

@VeereshAradhya
Copy link
Author

Marking the bug as closed as the test data that I used to test was not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants