You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@bobcatfish@vdemeester
For these Tekton Triggers go tests, should we follow the Pipeline repo's test format, and use the knative.dev/pkg/test library? For example, we'd probably create an init_test.go file similar to the one in Pipelines.
Expected Behavior
We should have a suite of end to end tests that we can use to test triggers functionality. We can start with a simple one that:
(If #36 happens first, this test can actually look for a running container, otherwise this will be a very light test!)
Actual Behavior
We've got a dummy test but not actually invoking any of our libs yet :D
Additional Info
One question at this point is do we want to use the knative test lib? I think it's probably simpler to use it, e.g.:
https://github.com/tektoncd/pipeline/blob/b91640d7db3d2de6fcb8c30c618a417047a03c12/test/embed_test.go#L69-L70
However it's not that complicated to implement our own (this is an example of what's required to hit most of the common stuff we'd need to do) https://github.com/bobcatfish/testing-crds/blob/master/client-go/test/cat_test.go#L136
Up to the implementer of this issue 😉 and also something we can easily change later!
The text was updated successfully, but these errors were encountered: