Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Triggers information to Resources #48

Closed
vtereso opened this issue Jul 30, 2019 · 2 comments
Closed

Add Triggers information to Resources #48

vtereso opened this issue Jul 30, 2019 · 2 comments
Assignees
@vincent-pli

Comments

@vtereso
Copy link

vtereso commented Jul 30, 2019 •
edited
Loading

Expected Behavior

Any resources created through Triggers should be properly labelled and annotated to specify their origins.

Actual Behavior

Currently, nothing does this.

Additional Info

Documentation should be included.
@vincent-pli vincent-pli mentioned this issue Aug 7, 2019
Closed
@vtereso vtereso mentioned this issue Sep 1, 2019
Merged
3 tasks
@vincent-pli
Copy link
Member

I think it should not set ownerReferences if the resource defined in triggerTemplate already has one. In such case, we suppose the resource has the garbage collection mechanism, we should keep it.

@vincent-pli
Copy link
Member

/assign @vincent-pli

@vincent-pli vincent-pli mentioned this issue Sep 5, 2019
Merged
3 tasks
@vtereso vtereso closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincent-pli vincent-pli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vincent-pli @vtereso