Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated params from TriggerTemplate spec #606

Closed
savitaashture opened this issue Jun 12, 2020 · 2 comments · Fixed by #690
Closed

Remove deprecated params from TriggerTemplate spec #606

savitaashture opened this issue Jun 12, 2020 · 2 comments · Fixed by #690
Assignees
@savitaashture
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
Triggers v0.7.0

Comments

@savitaashture
Copy link
Contributor

savitaashture commented Jun 12, 2020 •
edited

Background:

In order to avoid confusion from TriggerTemplate params with ResourceTemplate params we are replacing $(params) from ResourceTemplate to $(tt.params) as part of this PR

Currently in order to have a backward compatibility ResourceTemplate supports both $(params) and $(tt.params) for a release or two later need to remove $(params) from ResourceTemplate completely.

Creating this issue to track the removal of $(params) support from ResourceTemplate.
@savitaashture
Copy link
Contributor Author

/assign

@savitaashture savitaashture mentioned this issue Jun 12, 2020
Merged
3 tasks
@vdemeester
Copy link
Member

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 15, 2020
@dibyom dibyom added this to the Triggers v0.7.0 milestone Jul 8, 2020
@savitaashture savitaashture mentioned this issue Jul 28, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@savitaashture savitaashture

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
Triggers v0.7.0
4 participants
@vdemeester @dibyom @savitaashture @tekton-robot