Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to rename TriggerBinding #62

Closed
EliZucker opened this issue Aug 6, 2019 · 2 comments
Closed

Proposal to rename TriggerBinding #62

EliZucker opened this issue Aug 6, 2019 · 2 comments

Comments

@EliZucker
Copy link
Member

If we're including conditionals and headermatching in TriggerBinding, then I would propose renaming it to something like TriggerSifter (open to alternatives).

I suggest this because the TriggerBinding name was created to reflect how it binds values from the event payload onto the TrigerTemplate, however it will now also be doing filtering and headermatching. I think the name should change to reflect the fact that more processing is done than just binding values.

@ncskier
Copy link
Member

ncskier commented Aug 7, 2019

This is a good point, but I still don't mind the name TriggerBinding since we're binding event data to a set of output parameters (almost like a transformer). Plus there's conditional logic. So, I don't think it's necessary to change the name, but if we find one that sounds better, I wouldn't be opposed to an update.

I don't really like TriggerSifter because I think it loses the idea of the TriggerBinding having output information. But in the same vein, maybe something like TriggerRouter or EventRouter?

Since we're trying to make the TriggerBinding more reusable, maybe we can use the word Template with something like EventTemplate?

@bobcatfish
Copy link
Collaborator

I feel like these days TriggerBinding really only does binding, it no longer does anything conditional (I don't think?) since we moved that functionality into interceptors so I think the name was good in the end and we could close this issue?

@dibyom dibyom closed this as completed Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants