Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started clusterrolebinding namespace is wrong #990

Closed
nobody4t opened this issue Mar 10, 2021 · 5 comments · Fixed by #1106
Closed

Getting Started clusterrolebinding namespace is wrong #990

nobody4t opened this issue Mar 10, 2021 · 5 comments · Fixed by #1106
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@nobody4t
Copy link

nobody4t commented Mar 10, 2021

I have an ocp cluster 4.6.x.
And I tried the getting-started example.
But I got the error when I tried to feed the line from curl command as below:

{"level":"error","ts":"2021-03-10T10:02:02.425Z","logger":"eventlistener","caller":"sink/sink.go:223","msg":"failed to resolve bindings: error getting TriggerBinding : triggerbinding.triggers.tekton.dev \"getting-started-pipelinebinding\" not found","knative.dev/controller":"eventlistener","/triggers-eventid":"793466bf-fe86-4280-886b-9273c7531a35","/trigger":"","stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:223\ngithub.com/tektoncd/triggers/pkg/sink.Sink.HandleEvent.func1\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:127"}

But the triggerbinding: getting-started-pipelinebinding does exist. So I wonder how can I debug this?
Or is this a bug?

@nobody4t nobody4t added the kind/bug Categorizes issue or PR as related to a bug. label Mar 10, 2021
@dibyom
Copy link
Member

dibyom commented Mar 10, 2021

I've heard of a couple reports of this happening intermittently. Could you delete and recreate your EventListener? Does it work then?

@dibyom dibyom changed the title Fail to run the getting-started example in openshift Intermittent bindings not found Mar 10, 2021
@dibyom
Copy link
Member

dibyom commented Mar 10, 2021

@dongwangdw what version of openshift and Triggers are you using?

@nobody4t
Copy link
Author

I rechecked and it resulted from the failure of cluterrole binding. I made some changes in the getting-started, https://github.com/tektoncd/triggers/blob/main/examples/rbac.yaml#L61.

This file is referred in getting-started from example. In getting-started, namespace getting-started is used but it is default here. This will cause errors. The service account should has no permission to list the triggerbindings. But the error is confusing. I think the error should be improved for right hint. This should be permisson issue here.

@nobody4t
Copy link
Author

I just made it with the changes.

we can close this issue. But the getting-started exmaple should be improved.

@dibyom
Copy link
Member

dibyom commented Mar 11, 2021

Ah got it....I'll keep this issue open to fix the getting-started roles.

@dibyom dibyom changed the title Intermittent bindings not found Getting Started clusterrolebinding namespace is wrong Mar 11, 2021
@dibyom dibyom added this to the Triggers Beta milestone May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants