Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed tests #63

Open
linearray opened this issue Feb 17, 2023 · 2 comments
Open

Failed tests #63

linearray opened this issue Feb 17, 2023 · 2 comments
Assignees

Comments

@linearray
Copy link
Collaborator

https://github.com/tel/saltine/actions/runs/4007439690/jobs/7280132376

With ghc 9.2.2:

...Internal.Auth (one-time):

  Authenticates message: [Failed]
*** Failed! Falsified (after 4845 tests):
Message " k\250G1\DLE\232)"
(used seed 7838238530178328799)

We had a number of seemingly randomly failing tests in the past, maybe we can find out what is going on here.

@linearray
Copy link
Collaborator Author

linearray commented Feb 20, 2023

Another one: GHC 9.4.4 on macOS on amd64:

...Internal.Stream:
  xor munges input: [Failed]
*** Failed! Falsified (after 1 test):
Message "\NUL"
(used seed -4842425483227000893)

same thing on arm

...Internal.Stream:
  Stream is apropriately sized: [Arguments exhausted after 16885 tests]
  xor munges input: [Failed]
*** Failed! Falsified (after 1 test):
Message "\NUL"
(used seed 4324022072132119234)

@linearray linearray changed the title Failed test Failed tests Feb 20, 2023
@linearray
Copy link
Collaborator Author

The failures in the xor test were in all likelihood due to chance, because they all happened on a 1-byte bytestring a , and it's not unlikely to randomly generate another byte b such that a xor b = a (that b is 00000000 of course). Fixed in a0919e4

For now that leaves the failed test from the beginning of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant