Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cygnus] Allow disabling YAFS in order to avoid crashes upon configuration reloads #1074

Closed
frbattid opened this issue Jun 6, 2016 · 2 comments
Closed

[cygnus] Allow disabling YAFS in order to avoid crashes upon configuration reloads #1074

frbattid opened this issue Jun 6, 2016 · 2 comments
Assignees
@frbattid
Labels
bug minor
Milestone
release/1.8.0

Comments

@frbattid
Copy link
Member

frbattid commented Jun 6, 2016 •
edited by pcoello25

System output:

time=2016-07-05T09:26:03.840WET | lvl=ERROR | corr= | trans= | srv= | subsrv= | function=run | comp=Cygnus | msg=com.telefonica.iot.cygnus.nodes.CygnusApplication$YAFS[440] : Thread found not alive, exiting Cygnus. ID=23, name=Timer-0
Starting an ordered shutdown of Cygnus
Stopping sources
Stopping http-source (lyfecycle state=START)
@mariolg mariolg changed the title [cygnus] Cygnus crashes is the configuration file is change on the fly [cygnus] Cygnus crashes if the configuration file is changed on the fly Jun 6, 2016
@frbattid frbattid added this to the release/1.3.0 milestone Jul 5, 2016
@frbattid frbattid modified the milestones: release/1.4.0, release/1.3.0 Aug 29, 2016
@frbattid frbattid removed this from the release/1.4.0 milestone Sep 28, 2016
@frbattid frbattid added minor and removed P6 labels Apr 26, 2017
@frbattid
Copy link
Member Author

frbattid commented Apr 26, 2017 •
edited

Cygnus crashes because reloading the configuration implies killing threads running previous configuration components. When a thread is killed, Cygnus YAFS detects the thread has been killed and tries to completely kill Cygnus.

This could be avoided:

  • If YAFS knows the thread has been killed because of a configuration reloading. This seems hard to achieve.
  • or if we add the possibility to enable/disable YAFS.

@frbattid frbattid changed the title [cygnus] Cygnus crashes if the configuration file is changed on the fly [cygnus] Allow disabling YAFS in order to avoid crashes upon configuration reloads Apr 26, 2017
@frbattid frbattid self-assigned this Apr 26, 2017
@frbattid frbattid added this to the release/1.8.0 milestone Apr 26, 2017
@frbattid frbattid mentioned this issue Apr 27, 2017
Merged
@frbattid
Copy link
Member Author

Fixed in #1439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frbattid frbattid

Labels
bug minor
Projects
None yet
Milestone
release/1.8.0
Development

No branches or pull requests
2 participants
@frbattid @pcoello25