bug/1382_carto_enterprise_individual_accounts #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frbattid
commented
Jan 27, 2017
•
frbattid
commented
- Fixes issue [cygnus-ngsi][NGSICartoSink] Differentiate among enterprise and individual accounts #1382
- e2e tests done by @emepetres, who owns a personal Carto account with API key :)
…t type in carto keys file
… on the account type
fgalan
requested changes
Jan 27, 2017
| @@ -8,3 +8,4 @@ | |||
| - [cygnus-ngsi][hardening] Add raw bytes to NGSIEvent (#1345) | |||
| - [cygnus-ngsi][hardening] Add cache to NGSIMySQLSink (#130) | |||
| - [cygnus][hardening] Fix "FIWARE" name in license headers (#1369) | |||
| - [cygnus-ngsi][bug] Differentiate among enterprise and individual accounts (#1382) | |||
There was a problem hiding this comment.
Maybe better
[cygnus-ngsi][bug] Differentiate among enterprise and individual Carto accounts (#1382)
?
| @@ -31,6 +31,7 @@ | |||
| public class CartoDBBackendImpl extends HttpBackend implements CartoDBBackend { | |||
|
|
|||
| private final String apiKey; | |||
| private final boolean isPersonal; | |||
There was a problem hiding this comment.
isPersonal -> isPersonalAccount ?
fgalan
reviewed
Jan 27, 2017
| @@ -39,17 +40,23 @@ | |||
| * @param port | |||
| * @param ssl | |||
| * @param apiKey | |||
| * @param isPersonal | |||
|
LGTM |
fgalan
approved these changes
Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.