Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cygnus-ngsi][feature][NGSIElasticsearchSink] create NGSIElasticsearchSink #1516

Closed
nmatsui opened this issue Sep 17, 2018 · 5 comments · Fixed by #1523
Closed

[cygnus-ngsi][feature][NGSIElasticsearchSink] create NGSIElasticsearchSink #1516

nmatsui opened this issue Sep 17, 2018 · 5 comments · Fixed by #1523
Milestone
release/1.15.0

Comments

@nmatsui
Copy link
Contributor

nmatsui commented Sep 17, 2018

I want to use cygnus-ngsi with Elasticsearch. So I wrote conceptual implementations like below:

  • com.telefonica.iot.cygnus.sinks.NGSIElasticsearchSink
  • com.telefonica.iot.cygnus.backends.elasticsearch.ElasticsearchBackend
  • com.telefonica.iot.cygnus.backends.elasticsearch.ElasticsearchBackendImpl

What do you think about "ElasticsearchSink"? If you are interested in, I will write tests and documents and contribute this.
@nmatsui
Copy link
Contributor Author

nmatsui commented Sep 17, 2018

https://github.com/tech-sketch/fiware-cygnus/tree/feature/1516_create_elasticsearchsink

@fgalan
Copy link
Member

fgalan commented Sep 24, 2018

So you mean you have extended Cygnus with a new sink to persist data in Elasticsearch. Is my interpretation correct, please?

(Just to check if I'm understanding correctly the scope of the contribution... thx! :)

@nmatsui
Copy link
Contributor Author

nmatsui commented Sep 24, 2018

Yes, That's right. I want to contribute a new Sink and a new Backend to persist data to Elasticsearch.

@fgalan
Copy link
Member

fgalan commented Sep 25, 2018

Thanks for the clarification!

I think it would a good contribution to the sinks catalogue of Cygnus, so please go ahead with the PR and let's dicuss the details on its review. Thanks in advance for it!

@fgalan fgalan added this to the release/1.10.0 milestone Sep 25, 2018
@fgalan fgalan mentioned this issue Oct 15, 2018
Closed
@nmatsui nmatsui mentioned this issue Oct 17, 2018
Merged
@fgalan fgalan removed this from the release/1.10.0 milestone Dec 13, 2018
@fgalan
Copy link
Member

fgalan commented Jun 17, 2019

Implemented in PR #1523

@fgalan fgalan added this to the release/1.15.0 milestone Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release/1.15.0
Development

Successfully merging a pull request may close this issue.

Feature/1516 create elasticsearchsink tech-sketch/fiware-cygnus
2 participants
@nmatsui @fgalan