Arcgis sink. Wrong objectid in UpdateFeatures

[danielvillalbamota]

Context

When the sink check that a feature already exist by finding the uniquefield in the Feature Layer, it prepares the request to updateFeatures on that objectId, but instead of using the received objectId is using -1:

---BODY: features=%5B%7B%22geometry%22%3A%7B%22x%22%3A0.0%2C%22y%22%3A0.0%2C%22spatialReference%22%3A%7B%22wkid%22%3A4326%7D%7D%2C%22attributes%22%3A%7B%22OBJECTID%22%3A-1%2C%22...%7D%7D%5D&f=json

Problem

I guess the following code block is not finding any key as "OBJECTID_FIELDNAME" as long as the key is in fact "objectid" and "OBJECTID_FIELDNAME" is defined as private static final String OBJECTID_FIELDNAME = "OBJECTID";

fiware-cygnus/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/Feature.java

Lines 227 to 241 in 9d18551

	public Integer getObjectId() throws ArcgisException {
	Integer objectId = -1;
	for (Map.Entry<String, Object> attribute : attributes.entrySet()) {
	if (OBJECTID_FIELDNAME.equals(attribute.getKey())) {
	objectId = (Integer) attribute.getValue();
	break;
	}
	}
	if ("".equals(objectId)) {
	throw new ArcgisException("Cant find " + GisAttributeType.OID + " in Feature Object.");
	} else {
	return objectId;
	}
	}

So, one possible solution is to check the key using equalsIgnoreCase method.

[AlvaroVega]

another similar usage of setObjectId (

fiware-cygnus/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/Feature.java

Line 255 in 9d18551

if (OBJECTID_FIELDNAME.equals(attribute.getKey())) {

)

[fgalan]

PR #2315

[fgalan]

PR merged. Let's keep this issue opened, while @danielvillalbamota can confirm it is solved.

[danielvillalbamota]

It works, now is able to update features. I close the issue