New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[constants] Rename the header constants #662

Closed

frbattid opened this issue Dec 14, 2015 · 1 comment

Assignees

Labels

Milestone

Member

frbattid commented Dec 14, 2015

Proposed changes:

HEADER_NOTIFIED_SERVICE -> HTTP_HEADER_SERVICE
HEADER_NOTIFIED_SERVICE_PATH -> HTTP_HEADER_SERVICE_PATH
HEADER_DEFAULT_SERVICE_PATHS -> FLUME_HEADER_NOTIFIED_SERVICE_PATHS
HEADER_GROUPED_SERVICE_PATHS -> FLUME_HEADER_GROUPED_SERVICE_PATHS
HEADER_DEFAULT_DESTINATIONS -> FLUME_HEADER_NOTIFIED_ENTITIES
HEADER_GROUPED_DESTINATIONS -> FLUME_HEADER_GROUPED_ENTITIES

Effort: 1 man day

frbattid added techdebt must labels

frbattid self-assigned this

frbattid added this to the release/0.12.0 milestone

frbattid changed the title ~~[constants] Rename the header contants~~ [constants] Rename the header constants

frbattid mentioned this issue

hardening/662_rename_header_constants #663

Merged

Member Author

frbattid commented Dec 15, 2015

Implemented in PR #663

frbattid closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment