Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all sinks] Improve the different elements naming when notified/default service path is / #877

Closed
frbattid opened this issue Mar 16, 2016 · 3 comments
Assignees
Milestone

Comments

@frbattid
Copy link
Member

Current behaviour:

  • OrionHDFSSink: /user/myuser/myservice//myentityId_myentityType/myentityId_myentityType.txt
  • OrionMySQLSink: database myservice, table _myentityId_myentityType
  • OrionCKANSink: orgName myservice, pkgName myservice, resName myentityId_myentityType
  • OrionSTHSink/OrionMongoSink: database sth_myservice, collection sth_/_myentityId_myentityType
  • OrionKafkaSink: error --> "Path must not end with / character" !!!
  • OrionDynamoDBSink: myservice__myentityId_myentityType
  • OrionPostgreSQLSink: schema myservice, table _myentityId_myentityType

In addition, subsvc field in log4j logs is empty when / is notified (or configured as default).

Do we accept this default behaviour? Alternatives?

My proposal:

  • OrionHDFSSink --> / instead of //
  • OrionMySQLSink --> remove the initial _
  • OrionCKANSink --> it's OK
  • OrionMongoSink/OrionSTHSink --> they are OK
  • OrionKafkaSink --> must be fixed
  • OrionDynamoDBSink --> _ instead of __
  • OrionPostgreSQLSink --> remove the initial _
@frbattid frbattid self-assigned this Mar 16, 2016
@frbattid frbattid added this to the release/0.14.0 milestone Mar 16, 2016
@frbattid
Copy link
Member Author

This must be applied both to release/0.13.0 and release/0.14.0

@manucarrace
Copy link
Collaborator

LGTM

@frbattid
Copy link
Member Author

Implemented in PR #883 and PR #896 (develop branch)
Implemented in PR #886 and PR #897 (release/0.13.0 branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants