Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OrionKafkaSink] Expand topic name #880

Closed
frbattid opened this issue Mar 17, 2016 · 7 comments
Closed

[OrionKafkaSink] Expand topic name #880

frbattid opened this issue Mar 17, 2016 · 7 comments
Assignees
Milestone

Comments

@frbattid
Copy link
Member

Currently:

  • If data_model=dm-by-service then topic_name=<service>.
  • If data_model=dm-by-service-path then topic_name=<service-path>.
  • If data_model=dm-by-entity then topic_name=<entity>.
  • If data_model=dm-by-attribute then topic_name=<attribute>.

This should be instead ("normal" service-path starting with `/' ):

  • If data_model=dm-by-service then topic_name=<service>.
  • If data_model=dm-by-service-path then topic_name=<service>_<service-path_without_slash>.
  • If data_model=dm-by-entity then topic_name=<service>_<service-path_without_slash>_<entityId>_<entityType>.
  • If data_model=dm-by-attribute then topic_name=<service>_<service-path_without_slash>_<entityId>_<entityType>_<attrName>_<attrType>.

When the service-path is /:

  • If data_model=dm-by-service then topic_name=<service>.
  • If data_model=dm-by-service-path then topic_name=<service>.
  • If data_model=dm-by-entity then topic_name=<service>_<entityId>_<entityType>.
  • If data_model=dm-by-attribute then topic_name=<service>_<entityId>_<entityType>_<attrName>_<attrType>.

Effort: 1 man day

@frbattid frbattid added this to the release/0.14.0 milestone Mar 17, 2016
@pcoello25
Copy link
Contributor

Some tests are going to be implemented with the PR:

Getting service-path starts with '/' :

  • If data_model = dm-by-service then topic_name = <service>
  • If data_model = dm-by-service-path then topic_name = <service>_<service-path_without_slash>
  • If data_model=dm-by-entity then topic_name=<service>_<service-path_without_slash>_<entityId>_<entityType>.
  • If data_model=dm-by-attribute then topic_name=<service>_<service-path_without_slash>_<entityId>_<entityType>_<attrName>_<attrType>.

Getting service-path = '/' :

  • If data_model=dm-by-service then topic_name=<service>.
  • If data_model=dm-by-service-path then topic_name=<service>.
  • If data_model=dm-by-entity then topic_name=<service>_<entityId>_<entityType>.
  • If data_model=dm-by-attribute then topic_name=<service>_<entityId>_<entityType>_<attrName>_<attrType>.

@pcoello25
Copy link
Contributor

After reviews with this PR we are going to need 3 differents fixes now:

@pcoello25
Copy link
Contributor

Partially implemented in #905

@pcoello25
Copy link
Contributor

Current tests deleted in #915

@pcoello25
Copy link
Contributor

Partially implemented in #926

@pcoello25
Copy link
Contributor

Partially implemented in #929

@pcoello25
Copy link
Contributor

Implemented in #915 , #926, and #929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants