Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OrionKafkaSink] Create a KafkaBackend #912

Closed
frbattid opened this issue Apr 1, 2016 · 1 comment
Closed

[OrionKafkaSink] Create a KafkaBackend #912

frbattid opened this issue Apr 1, 2016 · 1 comment
Assignees
@pcoello25
Labels
should techdebt
Milestone
release/1.0.0

Comments

@frbattid
Copy link
Member

frbattid commented Apr 1, 2016

Currently, there is a mix in OrionKafkaSink:

  • There is a legacy persistenceBackend based on KafkaProducer.
  • There is a TopicAPI private class implementing certain backend functions.

Both of them must be joined in a KafkaBackend/KafkaBackendImpl with, at least, the following 3 methods:

  • boolean topicExists(ZkClient zookeeperClient, String topic)
  • void createTopic(ZkClient zookeeperClient, String topic, int partitions, int replicationFactor, Properties props)
  • send(ProducerRecord<String, String> record)

Effort: 1 man day
@frbattid frbattid added this to the release/0.14.0 milestone Apr 1, 2016
@pcoello25 pcoello25 mentioned this issue Apr 1, 2016
Merged
@pcoello25
Copy link
Contributor

Implemented in #914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcoello25 pcoello25

Labels
should techdebt
Projects
None yet
Milestone
release/1.0.0
Development

No branches or pull requests
2 participants
@frbattid @pcoello25