Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OrionRESTHandler] Mark as invalid configuration instead of exiting Cygnus upon wrong configuration #917

Closed
frbattid opened this issue Apr 4, 2016 · 1 comment
Closed

[OrionRESTHandler] Mark as invalid configuration instead of exiting Cygnus upon wrong configuration #917

frbattid opened this issue Apr 4, 2016 · 1 comment
Assignees
@frbattid
Labels
must techdebt
Milestone
release/1.0.0

Comments

@frbattid
Copy link
Member

frbattid commented Apr 4, 2016

Instead of exiting Cygnus upon wrong configuration (as currently done), better mark the confuration as invalid. So, when processing a new notification nothing must be done (i.e. an empty list of Flume events must be returned) if the configuration is invalid.

Effort: 1 man day
@frbattid frbattid self-assigned this Apr 4, 2016
@frbattid frbattid added this to the release/0.14.0 milestone Apr 4, 2016
@frbattid frbattid changed the title [OrionRESTHandler] Mark as invalid confiuration instead of exiting Cygnus upon wrong configuration [OrionRESTHandler] Mark as invalid configuration instead of exiting Cygnus upon wrong configuration Apr 4, 2016
@frbattid frbattid mentioned this issue Apr 4, 2016
Merged
@frbattid
Copy link
Member Author

frbattid commented Apr 5, 2016

Implemented in PR #918

@frbattid frbattid closed this as completed Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frbattid frbattid

Labels
must techdebt
Projects
None yet
Milestone
release/1.0.0
Development

No branches or pull requests
1 participant
@frbattid