New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not cast using NGSIv2 types in updateAction (version 2) #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlvaroVega
changed the title
Do not cast using NGSIv2 types
[WIP] Do not cast using NGSIv2 types
Oct 1, 2019
AlvaroVega
changed the title
[WIP] Do not cast using NGSIv2 types
[WIP] Do not cast using NGSIv2 types in updateAction with version 2
Oct 2, 2019
This was referenced Oct 2, 2019
Merged
AlvaroVega
changed the title
[WIP] Do not cast using NGSIv2 types in updateAction with version 2
Do not cast using NGSIv2 types in updateAction with version 2
Oct 7, 2019
@fgalan Which version is used by default (v1 or v2) for that notification? |
@fgalan Maybe we can add a configuration flag option (and env var) to enable or disable it, instead of remove all ? It would be disabled by default |
AlvaroVega
changed the title
Do not cast using NGSIv2 types in updateAction with version 2
Do not cast using NGSIv2 types in updateAction
Oct 16, 2019
AlvaroVega
changed the title
Do not cast using NGSIv2 types in updateAction
Do not cast using NGSIv2 types in updateAction (version1 and version 2)
Oct 17, 2019
fgalan
reviewed
Oct 17, 2019
fgalan
reviewed
Oct 17, 2019
….com/telefonicaid/perseo-fe into task/disable_ngsiv2_type_cast_values
Co-Authored-By: Fermín Galán Márquez <fgalan@users.noreply.github.com>
….com/telefonicaid/perseo-fe into task/disable_ngsiv2_type_cast_values
AlvaroVega
changed the title
Do not cast using NGSIv2 types in updateAction (version1 and version 2)
Do not cast using NGSIv2 types in updateAction (version 2)
Oct 17, 2019
fgalan
reviewed
Oct 17, 2019
Co-Authored-By: Fermín Galán Márquez <fgalan@users.noreply.github.com>
fgalan
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are some automatic cast about types:
What do we want?
Currently updateAction in version 2 is trying to cast (after expandVars) to NGSIv2 types like: