Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you guys please please add support for Deno deployment #1812

Open
Evertt opened this issue Mar 15, 2023 · 5 comments
Open

Can you guys please please add support for Deno deployment #1812

Evertt opened this issue Mar 15, 2023 · 5 comments
Labels
deno Issues specific to Deno v5
Milestone

Comments

@Evertt
Copy link

Evertt commented Mar 15, 2023

It's possible to import telegraf in Deno using import { Telegraf } from "npm:telegraf@4.12.2".
I mean when I run that locally, that works.
But for some reason that fails when trying to deploy it on Deno.

And then there are Deno friendly CDNs, and I've tried all of them with Telegraf, and all of them encounter an error for one reason or another.

Can you maybe please just make a port that is completely compatible with Deno, including its deployment platform?

@MKRhere
Copy link
Member

MKRhere commented Mar 15, 2023

What happens when you Deno Deploy with npm:telegraf?

In other news: Telegraf v5 will natively support Deno (WIP in feat-deno)

@Evertt
Copy link
Author

Evertt commented Mar 15, 2023

What happens when you Deno Deploy with npm:telegraf?

It just so happens that importing npm packages that way is not yet supported on Deno deploy.

In other news: Telegraf v5 will natively support Deno (WIP in feat-deno)

Oh really?! That's very exciting! What's the expected time-line?

@MKRhere
Copy link
Member

MKRhere commented Mar 16, 2023

npm packages that way is not yet supported

Right; would you be able to report the errors you faced with https://esm.sh/telegraf?

What's the expected time-line?

Unfortunately no real timeline yet; it's very close to ready, but announcing a date puts a lot of pressure on me, and I have other things to work on as well. But relatively soon!

@Evertt
Copy link
Author

Evertt commented Mar 24, 2023

I'm sorry I didn't respond anymore. I switched over to using a docker image from Deno and deploying that on Google Cloud and now I don't have to worry anymore about any restrictions that the Deno deployment environment has.

And uhm, I have a quite a lot on my plate right now, so I don't really feel for going back to check out what errors came out of esm.sh when trying to install telegraf. Sorry. 😓

@MKRhere
Copy link
Member

MKRhere commented Mar 25, 2023

No problem! We'll try to get the first alpha for v5 out in the coming weeks!

@MKRhere MKRhere added this to the v5.0 milestone Mar 25, 2023
@MKRhere MKRhere added deno Issues specific to Deno v5 labels Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deno Issues specific to Deno v5
Projects
None yet
Development

No branches or pull requests

2 participants