-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Monochrome Icon for Windows #17438
Comments
What if the taskbar is white? 🤔 |
The request is for a monochrome icon, not a white icon. The best practice would be for it to follow the system theme. (Black icon for light theme, white icon for dark theme) Allowing the user to manually select from blue, white or black would be a good solution as well. |
White icon is a monochrome icon since it has only two colors.
The question is how to follow it? You have a pixmap icon, you set it, you don't know what's the color of the taskbar, the result will be unpredictable, it may end white on white. |
Thanks for your comments. I know that other programs have the ability to skin their app based on the system theme so I know it's possible somehow. |
You mean apps written in WinAPI, right? tdesktop is written in Qt. And then even apps using system theme don't have monochrome icon. |
@ilya-fedin Monochrome icons on Linux would also be much appreciated. |
You can install an icon theme with monochrome icons (e.g. Papirus) on Linux |
Same for me as for @abb128 . I dunno how @ilya-fedin got it to change like that. Must have been something other than Papyrus. |
I don't think polluting Windows-specific issue with your problems is a good thing to do, folks. |
doesn't seem like this windows-specific issue is progressing towards any kind of resolution. you're just making every excuse to not do anything imao. |
It doesn't mean you can discuss a completely unrelated issue (a problem in existing feature implementation on one platform is not related to feature request on other platform) here. |
i wouldn't say it's unrelated. this is a feature request for monochrome icons for windows. i added that the same feature for gnome would be really nice, too. you claim it exists on gnome already, but it doesn't. a Papyrus icon hack - which doesn't work - is a hack, not a feature implemented by telegram-desktop. |
It exists. Not on GNOME exclusively, but on Linux. If it doesn't work for you, there's a bug somewhere and you should open a new issue and not polluting Windows-specific issues. I don't quite understand what do you mean by hack, it's the common icon theming mechanism used on Linux. |
um... a feature is when i can find a tickbox in telegram settings 'use monochrome icons', a hack is when i have to use a totally unrelated icon pack to achieve the same goal. |
|
okey-dokey |
I'd like to remind that this is still not done and it also affects Windows 11. For those who reminded that this is a Qt project (not a WinAPI project), Qt allows detecting dark mode since Qt 6.5. So, it is possible to implement this as most of the Qt based applications implemented it already. |
Can you point to those applications? Is system dark mode guaranteed to match the taskbar color? Also, tdesktop is stuck with Qt 5.15 due to Windows 7 support. |
I saw dark mode support on qBittorrent but it looks more of a hack than a proper solution. KeepassXC doesn't rely on Qt to detect dark mode which could be the way to go in Telegram as well. |
SystemUsesLightTheme key looks like exactly what's needed. Currently tdesktop uses only AppsUseLightTheme. |
It does not need to detect, but allowing users to change the tray icon from settings should be at least added to telegram. As it's a must tbh. |
@zelosleone don't expect a setting would be added |
Eh, why not? |
@zelosleone the practice is to avoid adding new settings |
As far as i see, experimental settings under advanced settings can be used for this. Also, some telegram alternative clients support this too, although they are extremely old and not updated in over 2 years. It's not that much of a change and i find it bad faith to not to include this tbh. |
@zelosleone i don't think this will be allowed to be in experimental settings. Detecting the system taskbar color is the only realistic way. |
@ildar170975 Maybe counter should be replaced with a small dot, like on Windows Update. |
@john-preston maybe just make the font smaller? It works on macOS after all. |
@ilya-fedin It was there from the beginning, so nothing unusual there. |
Please revert this, or like the original request asked, "and make that configurable in the settings". I can't distinguish telegram from other icons. I use Telegram all the time and this is the only change that has made me sad. |
Could you please revert this change. The message counter is now unreadable and it's difficult to quickly distinguish the Telegram icon from other tray icons. PS What a stupid tendency to make everything monochrome. Monochrome icons don't look good and lose their individuality. Even Microsoft acknowledged this in the Windows 11 Settings app. |
@john-preston you tread on my dreams... |
This whole Issue makes no sense. The Microsoft icons are monochrome and this makes them easy to distinguish from other apps. It makes no sense to turn everything monochrome. Besides. The Telegram icon was modern, it looked great, it was easy to spot from 12-20 icons in the tray. Now? It's a quest to find it. |
Who the hell thought this was a good idea? "Settings > Select Tray-Icon Style" "Monochrome [ ]" "Colored [X]" < This is the correct way. Jesus Christ. This is the first time considering searching for a forked version. Yes: It's this bad. |
@scorpion421 I saw the new option now... It's boring do this kind of stuff (customization), but this is the proper way to introduce new concepts without infuriating the old user base. |
Correct. This remembered me of Windows 8 because one wise guy said: "Yeah, it's good, make it" and then we had a menu looked like some pre-school kid did design. If you do a new design: Fine. But always leave the old one for users, managing the app with muscle memory. That also includes a simple icon. Yes, they fixed it now. But imagine nobody would have mentioned the bad decision. |
Is your feature request related to a problem?
The current blue telegram icon looks out of place in the Windows 10 system tray:
Describe the solution you'd like
You should consider replacing it with black and white to blend in like this and make that configurable in the settings:
Describe alternatives you've considered
n/a
Additional context
There are a few issues that mention this for windows but they're closed #1353 #3301
There's one for Linux in #1908 but it doesn't apply to windows
The text was updated successfully, but these errors were encountered: