Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Monochrome Icon for Windows #17438

Closed
livejamie opened this issue Dec 26, 2021 · 40 comments · Fixed by #26945
Closed

[Feature Request] Monochrome Icon for Windows #17438

livejamie opened this issue Dec 26, 2021 · 40 comments · Fixed by #26945

Comments

@livejamie
Copy link

Is your feature request related to a problem?

The current blue telegram icon looks out of place in the Windows 10 system tray:

image

Describe the solution you'd like

You should consider replacing it with black and white to blend in like this and make that configurable in the settings:

image

Describe alternatives you've considered

n/a

Additional context

There are a few issues that mention this for windows but they're closed #1353 #3301

There's one for Linux in #1908 but it doesn't apply to windows

@ilya-fedin
Copy link
Contributor

What if the taskbar is white? 🤔
White on white would look ugly

@livejamie
Copy link
Author

The request is for a monochrome icon, not a white icon.

The best practice would be for it to follow the system theme. (Black icon for light theme, white icon for dark theme)

Allowing the user to manually select from blue, white or black would be a good solution as well.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Dec 26, 2021

The request is for a monochrome icon, not a white icon.

White icon is a monochrome icon since it has only two colors.

The best practice would be for it to follow the system theme. (Black icon for light theme, white icon for dark theme)

The question is how to follow it? You have a pixmap icon, you set it, you don't know what's the color of the taskbar, the result will be unpredictable, it may end white on white.

@livejamie
Copy link
Author

Thanks for your comments.

I know that other programs have the ability to skin their app based on the system theme so I know it's possible somehow.

@ilya-fedin
Copy link
Contributor

You mean apps written in WinAPI, right? tdesktop is written in Qt. And then even apps using system theme don't have monochrome icon.

@ghost
Copy link

ghost commented Jun 5, 2022

@ilya-fedin Monochrome icons on Linux would also be much appreciated.

@ilya-fedin
Copy link
Contributor

Monochrome icons on Linux would also be much appreciated.

You can install an icon theme with monochrome icons (e.g. Papirus) on Linux

@abb128
Copy link

abb128 commented Jun 8, 2022

Monochrome icons on Linux would also be much appreciated.

You can install an icon theme with monochrome icons (e.g. Papirus) on Linux

This does not seem to affect the status icon
image

@ilya-fedin
Copy link
Contributor

It's supposed to.
изображение

@ghost
Copy link

ghost commented Jun 8, 2022

Same for me as for @abb128 . I dunno how @ilya-fedin got it to change like that. Must have been something other than Papyrus.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Jun 8, 2022

I don't think polluting Windows-specific issue with your problems is a good thing to do, folks.

@ghost
Copy link

ghost commented Jun 8, 2022

doesn't seem like this windows-specific issue is progressing towards any kind of resolution. you're just making every excuse to not do anything imao.

@ilya-fedin
Copy link
Contributor

It doesn't mean you can discuss a completely unrelated issue (a problem in existing feature implementation on one platform is not related to feature request on other platform) here.

@ghost
Copy link

ghost commented Jun 8, 2022

i wouldn't say it's unrelated. this is a feature request for monochrome icons for windows. i added that the same feature for gnome would be really nice, too. you claim it exists on gnome already, but it doesn't. a Papyrus icon hack - which doesn't work - is a hack, not a feature implemented by telegram-desktop.

@ilya-fedin
Copy link
Contributor

It exists. Not on GNOME exclusively, but on Linux. If it doesn't work for you, there's a bug somewhere and you should open a new issue and not polluting Windows-specific issues. I don't quite understand what do you mean by hack, it's the common icon theming mechanism used on Linux.

@ghost
Copy link

ghost commented Jun 8, 2022

um... a feature is when i can find a tickbox in telegram settings 'use monochrome icons', a hack is when i have to use a totally unrelated icon pack to achieve the same goal.
i get your point that the solution to my problem exists and i can obtain it by opening a bug report on papyrus github or whatev. but this is beside the issue. since telegram is cross-platform, i don't get why feature requests have to be windows-specific or linux-specific. i think 'make using monochrome icons an optional feature of telegram-desktop on all platforms' is a reasonable request. but maybe we should hear a third opinion.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Jun 8, 2022

  1. You don't need to open issue in Papirus repository, you need to open a new issue (of bug report type & filling all the required by issue template information) in tdesktop repository if you need help in finding out why tdesktop doesn't follow the chosen icon theme for you.
  2. This is OS-specific as every OS has different APIs. It's already implemented on macOS as it provides known API to detect the color of the panel. It's also implemented on Linux with icon theming so anyone can choose the appropriate icon for themselves by choosing the appropriate icon theme. No one here knows appropriate API on Windows, though.
  3. There's no tickbox for this feature on any platform as this feature is active out-of-the-box and @john-preston prefers not to add settings (there are feature requests for a tickbox to disable the feature, though).

@ghost
Copy link

ghost commented Jun 8, 2022

  1. you need to open a new issue (of bug report type & filling all the required by issue template information) in tdesktop repository

okey-dokey

#24584

@bravechamp
Copy link

I'd like to remind that this is still not done and it also affects Windows 11. For those who reminded that this is a Qt project (not a WinAPI project), Qt allows detecting dark mode since Qt 6.5. So, it is possible to implement this as most of the Qt based applications implemented it already.

@ilya-fedin
Copy link
Contributor

Can you point to those applications? Is system dark mode guaranteed to match the taskbar color?

Also, tdesktop is stuck with Qt 5.15 due to Windows 7 support.

@bravechamp
Copy link

I saw dark mode support on qBittorrent but it looks more of a hack than a proper solution. KeepassXC doesn't rely on Qt to detect dark mode which could be the way to go in Telegram as well.

@ilya-fedin
Copy link
Contributor

SystemUsesLightTheme key looks like exactly what's needed. Currently tdesktop uses only AppsUseLightTheme.

@zelosleone
Copy link

It does not need to detect, but allowing users to change the tray icon from settings should be at least added to telegram. As it's a must tbh.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Sep 16, 2023

@zelosleone don't expect a setting would be added

@zelosleone
Copy link

@zelosleone don't expect a setting would be added

Eh, why not?

@ilya-fedin
Copy link
Contributor

@zelosleone the practice is to avoid adding new settings

@zelosleone
Copy link

@zelosleone the practice is to avoid adding new settings

As far as i see, experimental settings under advanced settings can be used for this. Also, some telegram alternative clients support this too, although they are extremely old and not updated in over 2 years. It's not that much of a change and i find it bad faith to not to include this tbh.

@ilya-fedin
Copy link
Contributor

@zelosleone i don't think this will be allowed to be in experimental settings. Detecting the system taskbar color is the only realistic way.

@ildar170975
Copy link

With my all due respect - that was a dumb change.

  1. Can you find the icon here?
    изображение
  2. What makes you believe that 100% of users have "modern apps with modern monochrome icons"?

If you decided to change the icon - at least consider a user option to change it.
But no, you want others to experience your poor taste.

@john-preston
Copy link
Member

@ildar170975 Maybe counter should be replaced with a small dot, like on Windows Update.

@ilya-fedin
Copy link
Contributor

@john-preston maybe just make the font smaller? It works on macOS after all.

@john-preston
Copy link
Member

@ilya-fedin It was there from the beginning, so nothing unusual there.

@lazynooblet
Copy link

Please revert this, or like the original request asked, "and make that configurable in the settings". I can't distinguish telegram from other icons. I use Telegram all the time and this is the only change that has made me sad.

@Pathfinder9021
Copy link

Pathfinder9021 commented Oct 29, 2023

Could you please revert this change. The message counter is now unreadable and it's difficult to quickly distinguish the Telegram icon from other tray icons.

image

PS What a stupid tendency to make everything monochrome. Monochrome icons don't look good and lose their individuality. Even Microsoft acknowledged this in the Windows 11 Settings app.
image
https://www.microsoft.com/en-us/research/group/customer-insights-research/articles/why-your-users-value-color-icons-more-than-you-may-think/

@ildar170975
Copy link

@john-preston you tread on my dreams...
Please leave the counter.
And make icon colored again.
Do not follow trends which are wrongly considered as "modern & common".
Also, read about people who may distinguish objects by its colorS, not by its shape. Keyword - "accessibility".

@OpenSpaghettiSauce
Copy link

This whole Issue makes no sense. The Microsoft icons are monochrome and this makes them easy to distinguish from other apps. It makes no sense to turn everything monochrome.

Besides. The Telegram icon was modern, it looked great, it was easy to spot from 12-20 icons in the tray. Now? It's a quest to find it.

@navossoc
Copy link

Same...

image

Its the white icon... but which one?

@scorpion421
Copy link

scorpion421 commented Oct 31, 2023

Who the hell thought this was a good idea? "Settings > Select Tray-Icon Style" "Monochrome [ ]" "Colored [X]" < This is the correct way. Jesus Christ. This is the first time considering searching for a forked version. Yes: It's this bad.

@navossoc
Copy link

@scorpion421 I saw the new option now...
image

It's boring do this kind of stuff (customization), but this is the proper way to introduce new concepts without infuriating the old user base.

@scorpion421
Copy link

Correct. This remembered me of Windows 8 because one wise guy said: "Yeah, it's good, make it" and then we had a menu looked like some pre-school kid did design. If you do a new design: Fine. But always leave the old one for users, managing the app with muscle memory. That also includes a simple icon. Yes, they fixed it now. But imagine nobody would have mentioned the bad decision.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

13 participants