-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable bouncing app icon while receiving notification #897
Comments
@telegramdesktop: Methods to Override
See also: cancelUserAttentionRequest |
👍 |
Just comment out |
This feature would be super awesome. The bouncing is really unnecessary. |
Yes, it's not quite correct to ignore "Please, do not notify me at all" settings with this bouncing icon. With several multiuser chats it's getting unbearable :-( |
@koolkhel wait, icon bounces when notifications are disabled? |
Yes. All possible notifications (both inside Telegram and in macOS notification center) are disabled yet the icon bounces every received message. |
Then it should be a [bug], not an [enhancement] IMO. |
Confirm, in Telegram Desktop v0.10.19 from Appstore this bug is repeated |
Still exists in version 1.0. |
please fix this one, it makes the app unusable. the other mac client does not have this problem. |
From macOS Human Interface Guidelines
This bouncing should be deleted entirely, it's violating guidelines(what users expect from UI|UX) |
Please do something about this. It's REALLY driving me nuts. |
I subscribe to all the aforesaid. Developers, please! At least make an option to disable this. |
I agree with the others. Telegram is a great app, but it is unusable without deactivating that bouncing shit. |
I can't reproduce icon bouncing for muted chats. I like the fact icon bounces tbh. But for anyone who does not, here's the patch: (which you can submit as a PR -- easy pick, hehe) diff --git a/Telegram/SourceFiles/platform/mac/notifications_manager_mac.mm b/Telegram/SourceFiles/platform/mac/notifications_manager_mac.mm
index c6a61cbac99a..ac7e18a10f12 100644
--- a/Telegram/SourceFiles/platform/mac/notifications_manager_mac.mm
+++ b/Telegram/SourceFiles/platform/mac/notifications_manager_mac.mm
@@ -139,8 +139,7 @@ std::unique_ptr<Window::Notifications::Manager> Create(Window::Notifications::Sy
return nullptr;
}
-void FlashBounce() {
- [NSApp requestUserAttention:NSInformationalRequest];
+inline void FlashBounce() {
}
void CustomNotificationShownHook(QWidget *widget) { |
Enjoy |
@antonakv I don't want to disable bouncing completely, I just want Telegram to match Apple's guidelines and don't bounce. |
#1184 ? |
Please, please fix this one. It is very annoying and not along the Apple guidelines. |
Why this still not a thing? |
Any updates? Flashing taskbar icon is incredibly annoying on Windows. |
@reallyuniquename since devs ignore this for years, I wrote hacky console tool to patch executable and get rid of this stupid flashing. |
@mxs42 Incredible job, thank you so much for your universal patch. I've built your tool with VS and successfully patched Telegram binary.
Is it true though? Even if you completely disable Telegram notifications it still flashes its icon. In case someone uses old VS version: you have to switch project's toolset to earlier version and add |
@reallyuniquename idk, I don't even want to test it again xD |
well i guess this is never going to get fixed because the devs dgaf, but i would just like to register my opinion: the bouncing dock icon is extremely annoying! |
What's the reasoning for keeping this? I started using Telegram recently and that's one of the most annoying aspect of the native macos app |
@GuiSim fyi there are two telegram apps for macOS, and tdesktop (the one with bouncing icon) isn't the one which is usually referred to as "native". native usually refers to https://macos.telegram.org, not https://desktop.telegram.org. |
Please disable the bouncing. Modern macOS apps don't really use this bouncing effect anymore. Why be different ? Thank you! It's really annoying. |
Please, turn this annoying bouncing off |
I've visited this ticket many times and I'm very surprised it's getting no attention from the developers. I'm genuinely interested in knowing why. |
@oluwasayo I am pretty sure this issue is way down the bug queue. Give it few years, build your own version of Telegram client or use external patching tools to remove blinking. |
Stopped using desktop version because of that. |
$ defaults write com.apple.dock no-bouncing -bool TRUE |
You should disable notifications in telegram settings |
On Windows, the taskbar still flashes if notifications are disabled entirely in Telegram. So I guess this could be related to the issue on macOS. |
So this function is not planned to improve? Telegram is really one of the very few software that still has this annoying function. |
@p5ydn0 There is the same approach as with Helm 3 package manager. They don't care if there is a workaround. The style... |
@antonakv @p5ydn0 (and all the others who complain in this thread) Stop whining. Have you tried writing up a fix and submitting a pull request? I’m sorry that this app isn’t providing you with the expected value despite all the money that you have paid for being able to use it and have code insights |
Your logic is really strange. According to what you mean, when anyone who uses a certain software encounters a certain problem or a function they do n’t like, they should shut up and write the code quietly to solve it? So if someone encounters a bug while using the software, and he doesn't program, he can just shut up and suffer? One reason everyone complains is that we are using this software; since we are using this software, it means that we likes this software at least. Everyone discussing here is also making comments, hoping this software is getting better and better. It's you, instead, saying something strange and useless. |
Clueless. This issue in particular means that there is a UX problem for some users so they report about it. For future Windows users reading this topic: |
why instead make a tool you don't make a pull request to add the setting |
Because for me it was easier to make a tool and I never worked with QT. |
Yahooo!!! |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
bouncing app icon is so anoying
The text was updated successfully, but these errors were encountered: