Panel icon is blurry #9985

renyhp · 2020-12-23T17:20:18Z

Steps to reproduce

Set the Papirus icon theme
Open Telegram

Expected behaviour

The panel icon should be clear

Actual behaviour

The panel icon is blurry

Configuration

Operating system: Xubuntu 20.04.1 LTS

Version of Telegram Desktop: 2.5.1

Installation source (Linux Only): the official website

Used theme: Papirus

The Telegram icon is evidently more blurry than other icons.

ilya-fedin · 2020-12-23T17:35:19Z

tdesktop uses this algorithm to get icon:

tdesktop/Telegram/SourceFiles/platform/linux/main_window_linux.cpp

Lines 224 to 239 in feff514

    
           if (systemIcon.actualSize(desiredSize) == desiredSize) { 
        
           	currentImageBack = systemIcon 
        
           		.pixmap(desiredSize) 
        
           		.toImage(); 
        
           } else { 
        
           	const auto availableSizes = systemIcon.availableSizes(); 
        
           	const auto biggestSize = ranges::max_element( 
        
           		availableSizes, 
        
           		std::less<>(), 
        
           		&QSize::width); 
        
           	currentImageBack = systemIcon 
        
           		.pixmap(*biggestSize) 
        
           		.toImage(); 
        
           }

As you can see, it tries to get exactly needed size at first, but if icon theme doesn't have it, it gets the biggest size and scales it. Maybe your icon theme just doesn't contain needed size?

renyhp · 2020-12-23T17:43:51Z

These are the files in the icon theme:

/usr/share/icons/Papirus/16x16/panel/telegram-panel.svg
/usr/share/icons/Papirus/22x22/panel/telegram-panel.svg
/usr/share/icons/Papirus/24x24/panel/telegram-panel.svg

I tried setting the panel icon size to 22 or 24, restarting Telegram in between setting changes. The icon is still blurry.

ilya-fedin · 2020-12-23T17:49:23Z

I even can't reproduce this

renyhp · 2020-12-23T18:04:21Z

I'm happy to help reproduce the issue, if you can guide me. I have no experience in tdesktop code.

ilya-fedin · 2020-12-23T18:06:51Z

Do you have a tdesktop-trayicon-* file in /run/user/$UID (where $UID is UID of your user)?

renyhp · 2020-12-23T18:09:48Z

No.

/run/user$ find . -iname 'tdesktop*'
find: ‘./1000/inaccessible’: Permission denied

ilya-fedin · 2020-12-23T18:11:54Z

There's Logs spoiler in the issue template, I don't see it in your issue though.

renyhp · 2020-12-23T18:21:45Z

What logs should I report?

I tried simply opening the app from the command line, this is what happens:

$ telegram
[ALSOFT] (EE) Failed to set real-time priority for thread: Operation non permitted (1)
error: : cannot open
error: : cannot open
error: : cannot open
  OpenType support missing for "DAOpenSansRegular", script 11
  OpenType support missing for "DAOpenSansSemibold", script 32
  OpenType support missing for "DAOpenSansSemibold", script 14

If I run it with sudo the icon actually appears clear...

ilya-fedin · 2020-12-23T18:26:28Z

What logs should I report?

~/.local/share/TelegramDesktop/log.txt

renyhp · 2020-12-23T19:01:39Z

[2020.12.23 20:00:35] Launched version: 2005001, install beta: [FALSE], alpha: 0, debug mode: [TRUE]
[2020.12.23 20:00:35] Executable dir: /opt/Telegram/, name: Telegram
[2020.12.23 20:00:35] Initial working dir: /home/renyhp/.local/share/TelegramDesktop/
[2020.12.23 20:00:35] Working dir: /home/renyhp/.local/share/TelegramDesktop/
[2020.12.23 20:00:35] Command line: /opt/Telegram/Telegram -workdir /home/renyhp/.local/share/TelegramDesktop/ --
[2020.12.23 20:00:35] Executable path before check: /opt/Telegram/Telegram
[2020.12.23 20:00:35] Logs started
[2020.12.23 20:00:35] Launcher filename: appimagekit_46924f6eb8394393510aa1031f302145-Telegram_Desktop.desktop
[2020.12.23 20:00:35] Connecting local socket to /run/user/1000/2ce0f2a80cc9ae6f53407d730a2cce91-{87A94AB0-E370-4cde-98D3-ACC110C5967D}...
[2020.12.23 20:00:35] This is the only instance of Telegram, starting server and app...
[2020.12.23 20:00:35] Moved logging from '/home/renyhp/.local/share/TelegramDesktop/log_start0.txt' to '/home/renyhp/.local/share/TelegramDesktop/log.txt'!
[2020.12.23 20:00:35] Primary screen DPI: 96
[2020.12.23 20:00:35] Font: from ':/gui/fonts/DAOpenSansRegular.ttf' loaded 'DAOpenSansRegular'
[2020.12.23 20:00:35] Font: from ':/gui/fonts/DAVazirRegular.ttf' loaded 'DAVazirRegular'
[2020.12.23 20:00:35] Font: from ':/gui/fonts/DAOpenSansRegularItalic.ttf' loaded 'DAOpenSansRegularItalic'
[2020.12.23 20:00:35] Font: from ':/gui/fonts/DAVazirRegular.ttf' loaded 'DAVazirRegular'
[2020.12.23 20:00:35] Font: from ':/gui/fonts/DAOpenSansSemiboldAsBold.ttf' loaded 'DAOpenSansSemibold'
[2020.12.23 20:00:35] Font: from ':/gui/fonts/DAVazirMediumAsBold.ttf' loaded 'DAVazirMedium'
[2020.12.23 20:00:35] Font: from ':/gui/fonts/DAOpenSansSemiboldItalicAsBold.ttf' loaded 'DAOpenSansSemiboldItalic'
[2020.12.23 20:00:35] Font: from ':/gui/fonts/DAVazirMediumAsBold.ttf' loaded 'DAVazirMedium'
[2020.12.23 20:00:35] Font: from ':/gui/fonts/DAOpenSansSemiboldAsBold.ttf' loaded 'DAOpenSansSemibold'
[2020.12.23 20:00:35] Font: from ':/gui/fonts/DAVazirMediumAsBold.ttf' loaded 'DAVazirMedium'
[2020.12.23 20:00:35] Font: from ':/gui/fonts/DAOpenSansSemiboldItalicAsBold.ttf' loaded 'DAOpenSansSemiboldItalic'
[2020.12.23 20:00:35] Font: from ':/gui/fonts/DAVazirMediumAsBold.ttf' loaded 'DAVazirMedium'
[2020.12.23 20:00:35] App Info: reading settings...
[2020.12.23 20:00:35] App Info: reading encrypted settings...
[2020.12.23 20:00:35] Lang Info: Loaded cached, keys: 2910
[2020.12.23 20:00:35] OpenAL Logging Level: (not set)
[2020.12.23 20:00:35] Audio Playback Devices: Audio interno Stereo analogico;Audio interno Stereo analogico (echo cancelled with PC-LM1E Camera Stereo analogico)
[2020.12.23 20:00:35] Audio Playback Default Device: Audio interno Stereo analogico
[2020.12.23 20:00:35] Audio Capture Devices: CancelledNoise;PC-LM1E Camera Stereo analogico;Monitor of Audio interno Stereo analogico;Monitor of Audio interno Stereo analogico (echo cancelled with PC-LM1E Camera Stereo analogico)
[2020.12.23 20:00:35] Audio Capture Default Device: CancelledNoise
[2020.12.23 20:00:35] System tray available: [TRUE]
[2020.12.23 20:00:35] Not using D-Bus global menu.
[2020.12.23 20:00:35] Using Unity launcher counter.
[2020.12.23 20:00:35] Getting DE, XDG_CURRENT_DESKTOP: 'XFCE'
[2020.12.23 20:00:35] Getting DE, DESKTOP_SESSION: 'xubuntu'
[2020.12.23 20:00:35] Getting DE, KDE_SESSION_VERSION: ''
[2020.12.23 20:00:35] DE: XFCE
[2020.12.23 20:00:35] App Info: reading accounts info...
[2020.12.23 20:00:35] App Info: reading encrypted info...
[2020.12.23 20:00:35] App Info: reading map...
[2020.12.23 20:00:35] App Info: reading encrypted map...
[2020.12.23 20:00:35] App Info: reading encrypted user settings...
[2020.12.23 20:00:35] App Info: encrypted user settings read.
[2020.12.23 20:00:35] App Info: reading encrypted mtp data...
[2020.12.23 20:00:35] MTP Info: read keys, current: 5, to destroy: 0
[2020.12.23 20:00:35] Map read time: 0
[2020.12.23 20:00:35] App Info: reading encrypted mtp config...
[2020.12.23 20:00:35] Notification daemon product name: Xfce Notify Daemon
[2020.12.23 20:00:35] Notification daemon vendor name: Xfce
[2020.12.23 20:00:35] Notification daemon version: 0.4.4
[2020.12.23 20:00:35] Notification daemon specification version: 1.2
[2020.12.23 20:00:35] Notification daemon capabilities: actions, body, body-hyperlinks, body-markup, icon-static, x-canonical-private-icon-only
[2020.12.23 20:00:35] TCP Error: network - Network unreachable
[2020.12.23 20:00:35] HTTP Error: network error 99 - Network unreachable
[2020.12.23 20:00:35] Export Info: Destroy top bar by controller removal.
[2020.12.23 20:00:35] Using SNI tray icon.

ilya-fedin · 2020-12-23T19:02:31Z

Could please you show your list of panel applets?

renyhp · 2020-12-23T19:12:50Z

I hope this answers... if not, please point me to what I should report you

$ grep 'property name="plugin-' .config/xfce4/xfconf/xfce-perchannel-xml/xfce4-panel.xml 
      <property name="plugin-ids" type="array">
      <property name="plugin-ids" type="array">
    <property name="plugin-1" type="string" value="whiskermenu"/>
    <property name="plugin-2" type="string" value="separator">
    <property name="plugin-3" type="string" value="tasklist">
    <property name="plugin-4" type="string" value="separator">
    <property name="plugin-5" type="string" value="systray">
    <property name="plugin-6" type="string" value="notification-plugin"/>
    <property name="plugin-7" type="string" value="indicator">
    <property name="plugin-8" type="string" value="statusnotifier">
    <property name="plugin-10" type="string" value="pulseaudio">
    <property name="plugin-11" type="string" value="separator">
    <property name="plugin-12" type="string" value="clock">
    <property name="plugin-9" type="string" value="whiskermenu"/>
    <property name="plugin-13" type="string" value="separator">
    <property name="plugin-15" type="string" value="tasklist">
    <property name="plugin-16" type="string" value="separator">
    <property name="plugin-17" type="string" value="notification-plugin"/>
    <property name="plugin-18" type="string" value="statusnotifier">
    <property name="plugin-19" type="string" value="indicator">
    <property name="plugin-20" type="string" value="pulseaudio">
    <property name="plugin-21" type="string" value="separator">
    <property name="plugin-22" type="string" value="clock"/>

ilya-fedin · 2020-12-23T19:16:47Z

I need this

ilya-fedin · 2020-12-23T19:34:48Z

vokoscreen-2020-12-23_23-34-01.mp4

renyhp · 2020-12-23T19:36:00Z

In my understanding, those are taken from the file I grepped from. Anyway, here it is:

ilya-fedin · 2020-12-23T19:39:36Z

Oh. Its really, really weird. I thought that the XML is wrong, but looks like you really have three tray applets at once.

renyhp · 2020-12-23T19:45:16Z

Yes, I know, tray icons are a mess... Most of my applications (Telegram included) use statusnotifier. Claws Mail uses systray. Nothing is actually using indicator, but it was there by default. (And IIUC notification-plugin is not actually an applet adding tray icons)

ilya-fedin · 2020-12-23T19:47:52Z

I reproduced, it's a statusnotifier bug. Telegram provides an array of pixmaps with different sizes and the applet takes the biggest one and downscales it instead of just using the most appropriate one.

renyhp · 2020-12-23T19:49:55Z

Thank you!

Just a simple question: can Telegram work around this bug? Seems like other apps did that too...

ilya-fedin · 2020-12-23T19:51:01Z

Nothing is actually using indicator

Because both statusnotifier and indicator implement the same spec (indicator supports only a subset of the spec though, it's Canonical's implementation and used only in Ubuntu), they conflict and only one of them could work at the same time.

ilya-fedin · 2020-12-23T19:54:25Z

can Telegram work around this bug? Seems like other apps did that too...

Other applications don't have a counter and just supplying an icon name. Since tdesktop generates icon on the fly for the counter, the only way is to supplying pixmaps.

ilya-fedin · 2020-12-23T20:00:41Z

If you remove all tray applets except of systray (indicator, statusnotifier) from the list, all applications should start using it after a relogin.

renyhp · 2020-12-23T21:39:17Z

Well okay, I guess, but now all other apps have started glitching...

ilya-fedin · 2020-12-23T21:46:05Z

electron...

renyhp · 2020-12-23T21:55:51Z

Is there no way that telegram could use systray without the user having to remove statusnotifier from the panel? (Like Claws Mail is doing, for example)

ilya-fedin · 2020-12-23T22:01:03Z

looking by Qt code, there is no way.
https://github.com/qt/qtbase/blob/5.15/src/platformsupport/themes/genericunix/qgenericunixthemes.cpp#L205-L210
https://github.com/qt/qtbase/blob/5.15/src/platformsupport/themes/genericunix/qgenericunixthemes.cpp#L104-L115

ilya-fedin · 2020-12-23T22:03:23Z

I think you should ask (and maybe help) statusnotifier developers to fix it instead of searching for workarounds.

renyhp · 2020-12-24T11:23:47Z

I posted in statusnotifier bug list.

Something I was wondering though: if this were a problem with statusnotifier downscaling the wrong image, there should be one icon size that makes Telegram's icon nice and clean. I tried setting the panel icon size to various sizes and the icon is always blurrier than others.

16px:

22px:

24px:

48px:

64px:

ilya-fedin · 2020-12-24T12:13:06Z

Maybe your icon theme doesn't have 48px size? It's the biggest that Telegram provides and if statusnotifier uses it, it will be upscaled by Telegram if icon theme doesn't have such size and right after that downscaled by statusnotifier.

ilya-fedin · 2020-12-24T14:32:10Z

Looks like I found what's the problem: QIcon::actualSIze doesn't work as expected

github-actions · 2021-03-03T22:01:46Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Aokromes added the 3rd party issue label Dec 24, 2020

Aokromes closed this as completed Dec 24, 2020

ilya-fedin mentioned this issue Dec 24, 2020

Fix blurry tray icon with svg themes #9996

Merged

github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Panel icon is blurry #9985

Panel icon is blurry #9985

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020 •

edited

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020 •

edited

ilya-fedin commented Dec 23, 2020 •

edited

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020 •

edited

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020 •

edited

ilya-fedin commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020 •

edited

renyhp commented Dec 24, 2020

ilya-fedin commented Dec 24, 2020

ilya-fedin commented Dec 24, 2020

github-actions bot commented Mar 3, 2021

Panel icon is blurry #9985

Panel icon is blurry #9985

Comments

renyhp commented Dec 23, 2020

Steps to reproduce

Expected behaviour

Actual behaviour

Configuration

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020 • edited

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020 • edited

ilya-fedin commented Dec 23, 2020 • edited

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020 • edited

renyhp commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020

renyhp commented Dec 23, 2020 • edited

ilya-fedin commented Dec 23, 2020

ilya-fedin commented Dec 23, 2020 • edited

renyhp commented Dec 24, 2020

ilya-fedin commented Dec 24, 2020

ilya-fedin commented Dec 24, 2020

github-actions bot commented Mar 3, 2021

ilya-fedin commented Dec 23, 2020 •

edited

renyhp commented Dec 23, 2020 •

edited

ilya-fedin commented Dec 23, 2020 •

edited

ilya-fedin commented Dec 23, 2020 •

edited

renyhp commented Dec 23, 2020 •

edited

ilya-fedin commented Dec 23, 2020 •

edited