This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Minimize the chat state/complexity #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm very happy with how this turned out, the implementation is significantly improved and was able to (re) do it in a few hours. |
|
Few more cleanups in now, going to merge this shortly... |
quartzjer
added a commit
that referenced
this pull request
Feb 24, 2015
Minimize the chat state/complexity
|
Not introduced in this commit, but is the weird escaping intentional? https://github.com/telehash/telehash.org/blame/master/v3/channels/chat.md#L102 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing the current chat channel proved far too complex to be a minimal utility, this is an attempt to simplify it even further.
joinchannel for inviting and the joining process