Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

handshake key attached #140

Merged
merged 2 commits into from Feb 24, 2015
Merged

handshake key attached #140

merged 2 commits into from Feb 24, 2015

Conversation

quartzjer
Copy link
Member

This was prompted by @temas to simplify the key handshake, attaching the packet as the BODY.

@quartzjer
Copy link
Member Author

@temas how's this look?

@jbdatko
Copy link

jbdatko commented Feb 24, 2015

This is an armchair designer question, for that I apologize. But I'm curious :) so...

Any reason you didn't adopt JWK as the key transport mechanism? If you already committed to JSON, I think you are only saving a bit by putting the public key in binary. Also, you'll have to specify the binary format for each CS (maybe you already did this).

Perhaps you could map hashnames with the Key ID in the JWK model for example.

@quartzjer
Copy link
Member Author

Excellent question, as that was highly considered :)

Each Cipher Set does indeed specify the binary format for it's public key material, so future ones could definitely choose JWK for that purpose.

The problem(s) with requiring it for all by default is pretty simple and compound: other cipher sets (both 1a and 3a) use public keys that are not (yet) specified as JWK alg options, and the 1* sets are designed specifically for embedded/lightweight usage where ideally a complete handshake can fit in <100 byte MTUs (very size sensitive).

The mapping to/from JWKs is really straight forward so I expect a lot of interop/compatibility and future sets to use more of those defaults, but it's up to each cipher set to express its own requirements :)

@temas
Copy link
Member

temas commented Feb 24, 2015

+1

temas pushed a commit that referenced this pull request Feb 24, 2015
@temas temas merged commit df9c044 into master Feb 24, 2015
@quartzjer quartzjer deleted the handshake-key branch March 18, 2015 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants