Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in light mode #2262

Closed
tk-network opened this issue Jan 22, 2024 · 3 comments
Closed

Error in light mode #2262

tk-network opened this issue Jan 22, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@tk-network
Copy link

Scale Version
3.0.0-beta.147

Framework and version
plain html/js

Current Behavior
If I have activated the dark mode in the system, but force the light mode in the application with <body data-mode="light">, the text color is still white.
If I remove the data-mode attribute and use the system settings, everything works fine.
The error only occurs with plain html/js, with vue js everything works as usual.
Bildschirmfoto 2024-01-22 um 07 58 59

Expected Behavior
If I force the light mode, the light mode should also be used completely.

Desktop (please complete the following information):

  • OS: MacOS or Windows 11
  • Browser: chrome
  • Version: 120.0.6099.234
@tk-network tk-network added the bug Something isn't working label Jan 22, 2024
@Pravesh-mansharamani
Copy link

I think I can fix this, Can you please assign me this issue!

@felix-ico
Copy link
Collaborator

felix-ico commented Jan 23, 2024 •
edited
Loading

hi @tk-network I just tested this and could not reproduce the issue. Just to make sure, do you have

body {
  background-color: var(--telekom-color-background-canvas);
  // this is needed to overwrite standard html elements text color
  color: var(--telekom-color-text-and-icon-standard);
}

set in your css?

@tk-network
Copy link
Author

Yes, that was my mistake. Reading the documentation helps. :D
Thanks for the support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tk-network @felix-ico @Pravesh-mansharamani