Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the teleport-component-generator-react is not work when attrs's value is false #492

Closed
A-FE opened this issue Oct 22, 2020 · 6 comments · Fixed by #493
Closed

the teleport-component-generator-react is not work when attrs's value is false #492

A-FE opened this issue Oct 22, 2020 · 6 comments · Fixed by #493
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@A-FE
Copy link
Contributor

A-FE commented Oct 22, 2020

example

{
    "type": "element",
    "content": {
        "elementType": "text",
        "attrs": {
            "isCard": {
                "type": "static",
                "content": true
            },
            "extra": {
                "type": "static",
                "content": false
            }
        },
        "children": []
    }
}

expect

<span isCard extra={false}></span>

actually

<span isCard extra></span>
@JayaKrishnaNamburu
Copy link
Member

Hi @Good-Father thanks for reporting this, reproduction url --> https://repl.teleporthq.io/?uidlLink=xeki4sl1lbio9w7wn1xut

@JayaKrishnaNamburu JayaKrishnaNamburu added bug Something isn't working good first issue Good for newcomers labels Oct 22, 2020
@A-FE
Copy link
Contributor Author

A-FE commented Oct 22, 2020

@JayaKrishnaNamburu I am sorry, I can't. when I click the button "Share UIDL", the request "https://us-central1-croapp-dev.cloudfunctions.net/repl-api/upload-uidl" is always pending, I try to ping "us-central1-croapp-dev.cloudfunctions.net", but it is not work.

@JayaKrishnaNamburu
Copy link
Member

Hi @Good-Father i already made a reproduction url to reproduce the bug here --> https://repl.teleporthq.io/?uidlLink=xeki4sl1lbio9w7wn1xut

I will take a loot at this bug by the end of day. If you are interested in fixing it, i would like to help too 😄

@A-FE
Copy link
Contributor Author

A-FE commented Oct 22, 2020

@JayaKrishnaNamburu I'd love to fix it 😄 , I will pull request later

@JayaKrishnaNamburu
Copy link
Member

Sure, thank you. Let me know if you need any help in project setup 👍

@A-FE
Copy link
Contributor Author

A-FE commented Oct 22, 2020

@JayaKrishnaNamburu Hi, please review my PR #493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants