Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid - Filterrow - selecting operator triggers filtering & makes wide tables unusable #30

Closed
jannhofman opened this issue May 29, 2018 · 3 comments
Labels
Bug Item which indicates that something is not working pkg:Grid
Milestone

Comments

@jannhofman
Copy link

I'm submitting a...

  • Bug report

Current behavior

Create a table, resize a column - sidescrolling activates, and select in "Unit Price" e.g. "less than"
bug1
grafik

Changing the operator, without having any filter value triggers the filter, the result is empty and the scrollbar disapears. The user cant even reset oder change the filter in this case.

Expected behavior

We have 2 Issues.

  • filtering should not trigger if there is no value.
  • even in a table without rows, only displaying the table header, scrolling has to be possible

Environment

Package versions: 1
Browser: Firefox

@jannhofman jannhofman changed the title Filterrow - selecting operator triggers filtering & makes wide tables unusable Grid - Filterrow - selecting operator triggers filtering & makes wide tables unusable May 29, 2018
@Xizario
Copy link
Contributor

Xizario commented May 31, 2018

Changing the operator triggers filter always for some reasons:

  • Some operators works without value: isNull, isNotNull, isEmpty etc.
  • The programmer could handle the filter event and decide if he wants to process the new filters or not. Modify the value automatically or to ignore them. Thus the coder have full control.
  • Empty input is still a value for the string columns.
  • You could could always set back the filter prop to the grid, without new data prop.
  • If we fire events conditionally

The second one is real issue. We will fix it by adding ensuring the width of the data container is set even if there is no data to match the header.

@Xizario Xizario added Bug Item which indicates that something is not working pkg:Grid labels May 31, 2018
@jannhofman
Copy link
Author

Yeah, you are right its in between. We have full control, so i will add some consistency checks in the callback.

@Xizario Xizario added this to the 1.2.0 milestone Jul 9, 2018
@Xizario Xizario closed this as completed Jul 9, 2018
@Xizario
Copy link
Contributor

Xizario commented Jul 9, 2018

We have added empty message, localizated by default, and can be further customized with custom components using the inside the Grid. It is spanned thru the whole body of the grid, so the scroll will not disappear anymore after filtering returns empty data.

Will be available shortly in next uploaded dev version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Item which indicates that something is not working pkg:Grid
Projects
None yet
Development

No branches or pull requests

2 participants