Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

fix: update grid layout to be usable by theme-bootstrap #230

Merged
merged 35 commits into from
Feb 27, 2017

Conversation

joneff
Copy link
Contributor

@joneff joneff commented Feb 20, 2017

While vast, this refactoring is needed for Bootstrap theme to function properly.

@joneff joneff self-assigned this Feb 20, 2017
@joneff
Copy link
Contributor Author

joneff commented Feb 20, 2017

Few screens to show the visual differences in theme-bootstrap and the lack of in theme-default

theme-default
before:
image

after:
image

theme-bootstrap
before:
image

after:
image

Don't mind the pager links in bootstrap theme. That's something entirely different

@inikolova
Copy link
Contributor

inikolova commented Feb 21, 2017

Things, which should be fixed:

  • Grid headers, toolbar, filter row heights - should be 46px, currently are the same as the grid cells (36px);
  • Grid with aggregates and frozen columns - the whole layout is broken. Also, the layout in the Grid / Export to Excel demo;
  • Grid grouping header must have the same height in both cases - grouping applied and without grouping;
  • Missing top border on k-group-cell;
  • Grid headers don't show ellipsis when text overflows;
  • Double border on the last row - grid with frozen columns and aggregates;
  • Wrong padding on grid filter / column menu popups;
  • Wrong border colors of grid headers in IE11;

Copy link
Contributor

@inikolova inikolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment

@joneff
Copy link
Contributor Author

joneff commented Feb 22, 2017

Grid header, toolbar etc height fixed by f862287

@joneff
Copy link
Contributor Author

joneff commented Feb 27, 2017

@inikolova I think I fixed all the points.

On a side note, since flex does not support text-overflow: ellipsis I switched to using display: block for same of the cases.

@gyoshev
Copy link
Contributor

gyoshev commented Feb 27, 2017

@joneff please rebase and resolve the conflicts. Also, the commit messages won't push a new version -- consider squashing to a feat: or fix: commit.

@joneff joneff changed the title Grid refactoring fix: update grid layout to be usable by theme-bootstrap Feb 27, 2017
@inikolova
Copy link
Contributor

inikolova commented Feb 27, 2017

After additional testing I observed the following:

  • k-grouping-header is missing display: block definition;
  • Currently k-group-indicator is 40px high while it should be the same as a regular button (30px); -> FIXED
  • Grid k-grouping-dropclue is currently a vertical line, while it should have before / after elements; -> FIXED
  • Wrong .k-drag-clue height -> FIXED

@gyoshev
Copy link
Contributor

gyoshev commented Feb 27, 2017

@inikolova added the display:block. It is specific to the angular rendering, as we don't use block elements.

@gyoshev gyoshev merged commit ed746b2 into master Feb 27, 2017
@gyoshev gyoshev deleted the grid-refactoring branch February 27, 2017 16:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants