Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Update buttons styling #655

Merged
merged 4 commits into from
Aug 1, 2017
Merged

Update buttons styling #655

merged 4 commits into from
Aug 1, 2017

Conversation

inikolova
Copy link
Contributor

No description provided.

@@ -232,6 +233,7 @@
&::before {
content: "";
background-color: currentColor;
@include border-radius();
Copy link
Contributor

@gyoshev gyoshev Jul 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the design of the default theme does not have a border-radius on the bare buttons (link). This may be intentional for some uses in Kendo UI for jQuery (MediaPlayer / ToolBar?). If so (@joneff can confirm), it's better to leave it as a variable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thus far, only theme default seems like an exception. We could override border-radius only in the theme file.

If at a later stage we deem necessary we can introduce a variable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@gyoshev gyoshev merged commit 6346cbe into develop Aug 1, 2017
@gyoshev gyoshev deleted the update-buttons-styling branch August 1, 2017 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants