This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
fix: Editor toolbar styling #52 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyoshev
reviewed
Jan 10, 2017
| width: 100%; | ||
| height: 100%; | ||
| background-color: #000; | ||
| filter: alpha(opacity=50); |
There was a problem hiding this comment.
No need for filter, given our browser support.
| } | ||
|
|
||
| .k-editor .k-editor-toolbar-wrap, | ||
| .k-ct-popup .k-editor-toolbar, | ||
| .k-header.k-window-content.k-content { |
There was a problem hiding this comment.
.k-header.k-window-content.k-content does not say much. Perhaps we need a more descriptive class, or to drop some of the selectors?
| .k-ct-cell { | ||
| margin: $padding-y-sm / 2; | ||
| width: 20px; | ||
| height: 20px; |
There was a problem hiding this comment.
Is there a relationship between the .k-ct-popup width and padding, and the .k-ct-cell margin / width and height? It may be appropriate to calculate it. E.g. .k-ct-popup { width: $cell-width * 10; } means there will be 11 cells in the popup.
|
Added some comments. Please assign reviewers when posting PRs, to keep each other up-to-date. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds missing styles for the editor toolbar.