Skip to content

Commit

Permalink
fix(grid): improve grouping header layout in Angular
Browse files Browse the repository at this point in the history
also, improve style reuse to make it work for material and bootstrap with less styles
  • Loading branch information
gyoshev committed Apr 24, 2018
1 parent a7696e6 commit 1df42eb
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 17 deletions.
1 change: 0 additions & 1 deletion packages/bootstrap/scss/grid/_theme.scss
Expand Up @@ -99,7 +99,6 @@
// Grouping header
.k-grouping-header {
@include fill( $grid-header-text, $grid-header-bg, $grid-header-border );
padding: $toolbar-padding-y;
}
.k-grouping-header .k-group-indicator {
@include appearance( button );
Expand Down
22 changes: 14 additions & 8 deletions packages/default/scss/grid/_layout.scss
Expand Up @@ -29,6 +29,12 @@
$grid-filter-cell-padding-x: $cell-padding !default;
$grid-filter-cell-padding-y: $grid-cell-padding-y !default;
$grid-filter-input-text-indent: $padding-x !default;

$grid-grouping-header-padding-x: $toolbar-padding-y !default;
$grid-grouping-header-padding-y: $toolbar-padding-y !default;
$grid-group-indicator-border-radius: $border-radius !default;
$grid-group-indicator-gap: $cell-padding-y !default;

$grid-grouping-row-border-top: 1px !default;
$grid-group-footer-border-y: 1px !default;
$grid-group-footer-second-cell-border: 1px !default;
Expand Down Expand Up @@ -214,11 +220,11 @@
}
.k-group-indicator {
margin-right: 0;
margin-left: ( $cell-padding-y / 2 );
margin-left: ( $grid-group-indicator-gap / 2 );
}

.k-group-indicator + .k-group-indicator {
margin-right: ( $cell-padding-y / 2 );
margin-right: ( $grid-group-indicator-gap / 2 );
}

.k-grid-content-locked,
Expand Down Expand Up @@ -363,7 +369,7 @@
// Grouping header
.k-grouping-header {
display: block;
padding: $cell-padding-y;
padding: $grid-grouping-header-padding-y $grid-grouping-header-padding-x;
border-width: 0 0 1px;
border-style: solid;
border-color: inherit;
Expand All @@ -373,13 +379,13 @@
.k-grouping-header-flex {
display: flex;
flex-shrink: 0;
// use item margin instead of padding, in order to position the reorder clue correctly
padding: 0;

> .k-indicator-container {
display: inline-flex;
margin: 0;
padding: $padding-y 0 $padding-y $padding-x;
line-height: 1.5 * $form-line-height-em;
padding: $grid-grouping-header-padding-y 0 $grid-grouping-header-padding-y $grid-grouping-header-padding-x;

&:last-child {
flex-grow: 1;
Expand All @@ -389,7 +395,7 @@

.k-group-indicator,
.k-drag-clue {
@include border-radius();
@include border-radius( $grid-group-indicator-border-radius );
margin: 0;
padding: $button-padding-y $button-padding-x;
border-width: 1px;
Expand Down Expand Up @@ -435,11 +441,11 @@
}

.k-group-indicator {
margin-right: ( $cell-padding-y / 2 );
margin-right: ( $grid-group-indicator-gap / 2 );
}

.k-group-indicator + .k-group-indicator {
margin-left: ( $cell-padding-y / 2 );
margin-left: ( $grid-group-indicator-gap / 2 );
}

.k-grouping-dropclue {
Expand Down
12 changes: 4 additions & 8 deletions packages/material/scss/grid/_layout.scss
Expand Up @@ -16,15 +16,15 @@ $edit-cell-input-space: 0 !default;
$grid-header-first-border: 0 !default;
$grid-sorted-icon-margin-left: 8px !default;
$grid-header-menu-icon-spacing: 14px !default;
$grid-grouping-header-padding-x: 14px !default;
$grid-grouping-header-padding-y: 14px !default;
$grid-group-indicator-border-radius: add-two( $font-size, $button-padding-y) !default;
$grid-group-indicator-gap: 8px !default;

@import "~@progress/kendo-theme-default/scss/grid/layout";

@include exports ('grid/layout/material') {
$grid-header-font-size: 12px !default;
$grid-grouping-header-padding-x: 14px !default;
$grid-grouping-header-padding-y: 16px !default;
$grid-group-indicator-margin: 8px !default;
$grid-grouping-indicator-border-radius: add-two( $font-size, $button-padding-y) !default;
$grouping-dropclue-height: add-two( 2 * $font-size, 2 * $padding-y) !default;
$grouping-dropclue-margin-top: add-two( $grid-grouping-header-padding-x, (-1px)) !default;

Expand Down Expand Up @@ -92,12 +92,9 @@ $grid-header-menu-icon-spacing: 14px !default;
}

.k-grouping-header {
padding: $grid-grouping-header-padding-y $grid-grouping-header-padding-x;

.k-group-indicator {
border-width: 0;
border-radius: $grid-grouping-indicator-border-radius;
margin-right: $grid-group-indicator-margin;
}
}

Expand All @@ -106,7 +103,6 @@ $grid-header-menu-icon-spacing: 14px !default;
width: auto !important; // sass-lint:disable-line no-important
border-width: 0 !important; // sass-lint:disable-line no-important
line-height: 2 !important; // sass-lint:disable-line no-important
border-radius: $grid-grouping-indicator-border-radius;
font-size: $font-size;
}

Expand Down

0 comments on commit 1df42eb

Please sign in to comment.