Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(multiviewcalendar): disable outline of focused element telerik/kendo#15502 #3653

Merged
merged 2 commits into from Jun 20, 2022

Conversation

veselints
Copy link
Contributor

@veselints veselints commented Jun 13, 2022

The MultiViewCalendar k-calendar-view element should be the focusable element of the widget. Its outline, however, should not be visible as the active date is visually the focused element (using aria-activedescendant).

@veselints veselints self-assigned this Jun 13, 2022
@veselints veselints requested a review from a team as a code owner June 13, 2022 15:19
@veselints veselints requested a review from a team June 13, 2022 15:19
@joneff joneff added Bug Something isn't working C:MultiviewCalendar labels Jun 20, 2022
@joneff joneff added this to the 2022.3 milestone Jun 20, 2022
@joneff joneff merged commit 29e023b into develop Jun 20, 2022
@joneff joneff deleted the multiviewcalendar-no-outline branch June 20, 2022 08:25
@joneff
Copy link
Member

joneff commented Jun 20, 2022

on a serious note, we cannot know which element would be desired for the different suites. to facilitate development, we can have k-no-outline or k-outline-0 that deals with said behaviour.

@veselints
Copy link
Contributor Author

veselints commented Jun 20, 2022

@joneff The accessibility spec (in progress) requires focus to stay on the k-calendar-view element. Hence, all suites will have to comply with that requirement.
https://github.com/telerik/web-components-ux/pull/516

@joneff
Copy link
Member

joneff commented Jun 20, 2022

That wasn't a remark to you as much as it was a remark to us -- for certain scenarios where linear behaviour is require i.e. hide outline on a specific element, such class name would make it much easier.

it will also help determine if the various suites have consciously stepped towards implementing the spec, rather than getting some things "for free".

joneff pushed a commit that referenced this pull request Jul 5, 2022
joneff pushed a commit that referenced this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working C:MultiviewCalendar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants