Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected dark color of primary button and selected button in button group since 5.8.2-dev.5 #4041

Closed
Tracked by #4176
Dimitar-Goshev opened this issue Oct 11, 2022 · 1 comment · Fixed by #4216
Closed
Tracked by #4176
Labels
C:Buttongroup FW:jQuery Issue related to kendo-jquery SEV: Low T:Bootstrap Kendo Theme Bootstrap

Comments

@Dimitar-Goshev
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

To reproduce
Steps to reproduce the behavior:

  1. Use the following setup https://dojo.telerik.com/@Dimitar-Goshev/uZiyARas and reference the bootstrap-main-dark swatch from 5.8.2-dev.5

Actual behavior
The text color of selected buttongroup button is dark as on the screenshot below

Expected behavior
The text color of selected buttongroup button is lights as on the above Dojo

Screenshots
image

Affected package (please remove the unneeded items)

  • theme-bootstrap

Affected suites (please remove the unneeded items)

  • Kendo UI for jQuery

Affected browsers (please remove the unneeded items)

  • All

Build system information (please remove the unneeded items)

  • Not Applicable
@Dimitar-Goshev Dimitar-Goshev added Bug Something isn't working C:Buttongroup T:Bootstrap Kendo Theme Bootstrap FW:jQuery Issue related to kendo-jquery SEV: Low labels Oct 11, 2022
@joneff joneff removed the Bug Something isn't working label Jan 12, 2023
@joneff
Copy link
Member

joneff commented Jan 12, 2023

While it may seem counter intuitive, the reported issue is not a bug, but rather a statement: indeed the contrast color of that particular shade of blue is black, rather than white.

That's not to say we are leaving the issue like that, or we are not targeting it -- quite the contrary -- we are! While implementing a fix regarding dark themes in general, we took the opportunity to transfer the logic of Bootstrap 5.3.0-alpha for dark themes into our.

It's not perfect yet, but that's still an alpha... Sill, the improvement targets this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Buttongroup FW:jQuery Issue related to kendo-jquery SEV: Low T:Bootstrap Kendo Theme Bootstrap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants