Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$input-btn-border-width on bootstrap 5.3 is a custom variable (on 5.2 was a simple scss variable) #4535

Open
meriturva opened this issue Jun 8, 2023 · 4 comments
Labels
Bug Something isn't working

Comments

@meriturva
Copy link

meriturva commented Jun 8, 2023

See here:

https://github.com/twbs/bootstrap/blob/main/scss/_variables.scss#LL804C1-L804C24

$input-btn-border-width is now a custom variable.

(see bootstrap 5.2 version: https://github.com/twbs/bootstrap/blob/v5.2.3/scss/_variables.scss#L738 where $input-btn-border-width was a simple scss variable)

The main problem is that on file:

@progress\kendo-theme-bootstrap\scss\input\_variables.scss you are using:

$kendo-input-border-width: $input-border-width !default;
$kendo-input-border-height: ( $kendo-input-border-width * 2 ) !default;

so scss compilation gives me an error:

SassError: Undefined operation "var(--bs-border-width) * 2".
   ╷
10 │ $kendo-input-border-height: ( $kendo-input-border-width * 2 ) !default;

My temporary fix is to define, before importing _variables file:

$kendo-input-border-width: 1px !default;

Basically, the main problem is that package @progress/kendo-theme-bootstrap 6.4.0 with bootstrap 5.3 doesn't work anymore.

Feedback item: https://feedback.telerik.com/themes/1611266

Diego

@meriturva meriturva added the Bug Something isn't working label Jun 8, 2023
@Camo30
Copy link

Camo30 commented Sep 15, 2023

Same here. Seems that this package is not yet compatible with bootstrap 5.3, tested up to recent version 5.3.2.
Temporary fix is to downgrade to bootstrap 5.2.3.

@vveesseelliinnaa
Copy link

Reported again in Ticket ID: 1627146

@vveesseelliinnaa
Copy link

Reported again in Ticket ID: 1627595

@AStoker
Copy link

AStoker commented Mar 11, 2024

Running into a similar issue that appears related. Same kind of error, but regarding the $kendo-button-border-width in the multiselect element.

Undefined operation "var(--bs-border-width) * 2".
   ╷
69 │ $kendo-button-calc-size: calc( #{$kendo-button-line-height * 1em} + #{$kendo-button-padding-y * 2} + #{$kendo-button-border-width * 2} ) !default;
   │                                                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
  node_modules\@progress\kendo-theme-bootstrap\scss\button\_variables.scss 69:104  @import
  node_modules\@progress\kendo-theme-bootstrap\scss\button\_index.scss 21:9        @import
  @progress\kendo-theme-bootstrap\scss\multiselect\_index.scss 21:9                @import

Downgrading bootstrap to specifically 5.2.3 (was 5.3.3) fixes me for now, but that's not a real solution (especially for a ticket that's been open for months now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants