Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 9 not detected as Android OS by kendo.support.mobileOS.android #4357

Closed
Dimitar-Goshev opened this issue Jul 5, 2018 · 5 comments
Closed
Assignees
Milestone

Comments

@Dimitar-Goshev
Copy link
Contributor

Dimitar-Goshev commented Jul 5, 2018

Bug report

Currently Android 9, which is still not officially released, is reported as Android 9 in user agent strings, e.g.
Mozilla/5.0 (Linux; Android 9; Pixel Build/PPP3.180510.008) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Mobile Safari/537.36
Thus, kendo.support.mobileOS.android does not detect is as Android.

NOTE: If the version in the UAS is Android 9.0, instead of just Android 9, then it is properly recognized as Android. Most probably when Android 9 becomes official, it will become Android 9.0, so this issue should be tested once Android 9 is officially released.

Reproduction of the problem

  1. Create a custom mobile device in Chrome emulation tool with the user agent string above.
  2. Select this custom device in Chrome and load the following Dojo snippet

Current behavior

The device OS is not recognized as Android.

Expected/desired behavior

The device OS is recognized as Android and android appears in alert.

Environment

  • Kendo UI version: 2018.2.620
  • Browser: [Chrome 67 on Android 9]
@m1is
Copy link

m1is commented Aug 13, 2018

What's the status of this? Is there a workaround until it's fixed?

@mkihellas
Copy link

Hello, we have the same problem when running Kendo UI Core with Android 9 Pixel. The device OS is not recognized as an Android device thus our application is broken.

Would be nice to have an official answer from Kendo UI Core team for this issue and a possible fix. Thanks.

@mkihellas
Copy link

In order to fix the issue on Kendo UI Core you can change the regex that identifies the mobile OS from Kendo UI Core (kendo.core.js) from:
android: /(Android|Android.*(?:Opera|Firefox).*?\/)\s*(\d+)\.(\d+(\.\d+)?)/ with:
android: /(Android|Android.*(?:Opera|Firefox).*?\/)\s*(\d+)((\.)(\d+(\.\d+)?)|(?!\.))/ in order to identify Android 9 versions as it should.

@m1is
Copy link

m1is commented Sep 13, 2018

Is there any hope of Telerik incorporating this simple fix so I don't have to remember to go into their source code every time I need to get a new version?

@joneff joneff self-assigned this Sep 14, 2018
@joneff joneff modified the milestone: 2018.R3.SP.next Sep 14, 2018
@joneff
Copy link
Member

joneff commented Sep 14, 2018

Fixed by telerik/kendo@77f9e90f7054a7790f5c1c8d6a7b0fadcab81478.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants