Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolBar click event for splitButton's menuButtons does not fire when the splitButton is in overflow #4542

Closed
IvanDanchev opened this issue Sep 26, 2018 · 6 comments
Assignees
Labels
Bug C: ToolBar FP: Completed Sync status with associated Feedback Item jQuery SEV: Medium
Milestone

Comments

@IvanDanchev
Copy link
Contributor

IvanDanchev commented Sep 26, 2018

Bug report

The splitButton's own click event does not fire for its menuButtons, when the splitButton is displayed under the ToolBar's overflow button.

Reproduction of the problem

Dojo example.

  1. Resize the window so that the splitButton is moved under the overflow button.
  2. Open the overflow popup.
  3. Click on the splitButton items ("Option 1" or "Option 2").

Current behavior

The splitButton click event does not fire.

NOTE: if the main button of the splitButton is clicked, the event is fired.

Expected/desired behavior

The splitButton click event fires regardless of the splitButton being in overflow or in main toolbar.

Environment

  • Kendo UI version: 2019.3.1023
  • Browser: all
@veselints
Copy link
Contributor

Also reported in Ticket ID: 1426013

@Dimitar-Goshev Dimitar-Goshev changed the title ToolBar splitButton click event does not fire when the splitButton is in overflow ToolBar click event for splitButton's menuButtons does not fire when the splitButton is in overflow Nov 13, 2019
@GaloisGirl
Copy link
Contributor

GaloisGirl commented Feb 27, 2020

It works fine if the splitButton items have their own click handlers defined.

I think a more accurate description would be:

  1. when not overflown, the children without their own handler properly inherit the click handler from the parent
  2. when overflown, such children don't inherit the handler.

Demo: https://dojo.telerik.com/@GaloisGirl/UYeBewEX

@IvanDanchev
Copy link
Contributor Author

Also reported in Ticket ID: 1463102

@icesasoftcorp
Copy link

icesasoftcorp commented May 8, 2020

the problem is when it is for a mobile phone and the buttons overflow the menubuttons click does not work.
use the @GaloisGirl example and it is emulated on a mobile, and the click does not work.

image

@GaloisGirl
Copy link
Contributor

Revisiting this today I noticed that per the documentation, the children don't have their own click handlers: https://docs.telerik.com/kendo-ui/api/javascript/ui/toolbar/configuration/items.menubuttons

However, you can declare such handlers, and they work.

I'd really prefer for them to have their own click handlers: if I'm using different buttons, it's for doing different things.

@veselints veselints self-assigned this Dec 29, 2020
@kendo-bot kendo-bot added FP: Planned Sync status with associated Feedback Item FP: In Development Sync status with associated Feedback Item and removed FP: Planned Sync status with associated Feedback Item labels Dec 29, 2020
@mparvanov mparvanov added this to the 2021.R1.SP.next milestone Jan 26, 2021
@kendo-bot kendo-bot added FP: Completed Sync status with associated Feedback Item and removed FP: In Development Sync status with associated Feedback Item labels Jan 26, 2021
@Dimitar-Goshev
Copy link
Contributor

Dimitar-Goshev commented Dec 22, 2021

@GaloisGirl @icesasoftcorp We have logged a Feature Request for adding official support for separate subitem click handler and you may vote for it. Currently it is possible to assign different values to different splitButton's menuButtons and check in the splitButton click handler which menuButton is the one clicked. This is shown on ToolBar Events demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug C: ToolBar FP: Completed Sync status with associated Feedback Item jQuery SEV: Medium
Projects
None yet
Development

No branches or pull requests

7 participants