Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Databound Spreadsheet loses data on inserting a header row #5301

Closed
aleksandarevangelatov opened this issue Oct 1, 2019 · 1 comment
Closed
Assignees
Labels
Bug C: Spreadsheet FP: Completed Sync status with associated Feedback Item jQuery SEV: High
Milestone

Comments

@aleksandarevangelatov
Copy link
Contributor

aleksandarevangelatov commented Oct 1, 2019

Bug report

Following the KB Create Header and Footer Rows for a Spreadsheet with DataSource results in data loss on creating the custom header row. Upon inserting a row the data in cell A1 is removed.

Reproduction of the problem

Open this Dojo and run it.

Current behavior

Spreadsheet DataSource is loaded correctly, but after the 2 sec timeout on inserting a new row, the data in cell A1 (A2 after row insertion) is removed.

Expected/desired behavior

New row should be inserted without data loss in cell A1.

Environment

  • Kendo UI version: 2019.3.917
  • Browser: [all]
@kendo-bot kendo-bot added the FP: Unplanned Sync status with associated Feedback Item label Oct 1, 2019
@Dimitar-Goshev Dimitar-Goshev changed the title Spreadsheet looses data on insert of new header row Databound Spreadsheet loses data on inserting a header row Oct 4, 2019
@zdravkov zdravkov self-assigned this Oct 15, 2019
@nenchef nenchef added the FP: Planned Sync status with associated Feedback Item label Oct 15, 2019
@kendo-bot kendo-bot removed the FP: Unplanned Sync status with associated Feedback Item label Oct 15, 2019
@zdravkov zdravkov added this to the 2019.R3.SP.next milestone Oct 15, 2019
@kendo-bot kendo-bot added FP: In Development Sync status with associated Feedback Item and removed FP: Planned Sync status with associated Feedback Item labels Oct 15, 2019
@Dimitar-Goshev
Copy link
Contributor

In R3 2019 SP1 this issue will be resolved with the introduction of a second parameter to the insertRow method:

skipDataSourceInsert Boolean optional

If passed true, the method does not delete item from the DataSource.

Thus, in databound scenarios when inserting rows outside the databound rows, insertRow()'s parameter skipDataSourceInsert should be set to true to avoid the issue from the KB.
sheet.insertRow(0, true); // the second parameter skips the update of the dataSource

We will update the documentation and KB article once R3 2019 SP1 is released.

@kendo-bot kendo-bot added FP: Completed Sync status with associated Feedback Item and removed FP: In Development Sync status with associated Feedback Item labels Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug C: Spreadsheet FP: Completed Sync status with associated Feedback Item jQuery SEV: High
Projects
None yet
Development

No branches or pull requests

5 participants