Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimePicker does not scroll to selected value #6276

Closed
gyankov opened this issue Feb 8, 2021 · 4 comments
Closed

TimePicker does not scroll to selected value #6276

gyankov opened this issue Feb 8, 2021 · 4 comments
Assignees
Labels
Bug C: TimePicker FP: Completed Sync status with associated Feedback Item SEV: Medium
Milestone

Comments

@gyankov
Copy link

gyankov commented Feb 8, 2021

Bug report

Timepicker does not scroll to selected value. For more information and a sample refer to ticked with id 1505670.

Environment

  • Kendo UI version: 202x.r.ddd
  • jQuery version: x.y
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
@gyankov
Copy link
Author

gyankov commented Feb 9, 2021

The issue seems to be caused by the SASS themes. When using a LESS theme the k-list ul overflows its parent, thus the scroll appears to the parent div, which is the expected behavior.

@PreslavKozovski could you please look into this?

@gyankov gyankov removed their assignment Feb 9, 2021
@PreslavKozovski
Copy link
Contributor

Based on my tests, I think that the issue is caused by a new behavior of the JavaScript that sets display: flex; to the k-list-container k-list-scroller element.

I believe that assigning display: flex; to this element with JS is the correct behavior as it is flex from the CSS. However, this breaks the logic of the overflowing child element which we use for the scrolling.

For the tests, I used the following Dojos:
https://dojo.telerik.com/EQIJacOK - 2021.1.119
https://dojo.telerik.com/usezafIW - 2019.3.917
https://dojo.telerik.com/ibuYijAF - 2021.1.119 (styles) & 2019.3.917 (JS)

@gyankov
Copy link
Author

gyankov commented Feb 9, 2021

The issue appears to be related to the following commit:

Once I override the display setting of the k-popup class, the issue does not seem to reproduce:

@gyankov gyankov self-assigned this Feb 10, 2021
@dmanova

This comment has been minimized.

@dmanova dmanova added the FP: Completed Sync status with associated Feedback Item label Feb 17, 2021
@dmanova dmanova added this to the 2021.R1.SP.next milestone Feb 17, 2021
@dmanova dmanova closed this as completed Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug C: TimePicker FP: Completed Sync status with associated Feedback Item SEV: Medium
Projects
None yet
Development

No branches or pull requests

4 participants