Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The imageClass of the TreeList command column has no effect #7298

Closed
eyupyusein opened this issue Apr 10, 2023 · 3 comments
Closed

The imageClass of the TreeList command column has no effect #7298

eyupyusein opened this issue Apr 10, 2023 · 3 comments
Assignees
Labels
Bug C: TreeList FP: Completed Sync status with associated Feedback Item jQuery SEV: Medium

Comments

@eyupyusein
Copy link
Contributor

eyupyusein commented Apr 10, 2023

Bug report

The imageClass setting of the TreeList command column doesn't work (neither in jQuery/MVC/Core)
Currently undefined class is added to the 'k-button' element.

Reproduction of the problem

  1. Run the example in the API - https://docs.telerik.com/kendo-ui/api/javascript/ui/treelist/configuration/columns.command#columnscommandimageclass

Current behavior

There is no icon added in the command button and undefined class is added to the 'k-button' element.

Expected/desired behavior

There should be icon displayed in the button based on the added class in the imageClass configuration option

The issue is a regression - Starting with the 2023 R1 SP1 release

Note: Starting with the 2022 R1 release undefined class is added to the k-button element, but still the icon is displayed as icon classes are added to the inner span element.

Rendering with 2022 R1
image

Rendering starting with 2023 R1 SP1
image

Workaround

dataBound: function(){
$('.k-button-text').addClass('k-icon k-i-trash k-button-icon')
$('.k-button-text').text('')
},
Dojo - https://dojo.telerik.com/@NeliKondova/oPEvOcus

Environment

  • Kendo UI version: 2023.1.425
  • Browser: [all ]
@github-actions github-actions bot added the FP: Unplanned Sync status with associated Feedback Item label Apr 10, 2023
@nelito987
Copy link
Contributor

Reported in ticket ID: 1609147

@pepinho24 pepinho24 self-assigned this May 31, 2023
@pepinho24
Copy link
Contributor

With the 2023 R1 SP1 release, to show the icon, either a font one or an SVG one, you would need to simply declare the icon name via the .icon property instead of the .imageClass one. The image class will just add the class to the icon element if you need it for further customization of the icon.

@github-actions github-actions bot added FP: Completed Sync status with associated Feedback Item and removed FP: Unplanned Sync status with associated Feedback Item labels Jun 13, 2023
@palhal
Copy link

palhal commented Jun 18, 2023

I'm experiencing this issue as well when using the ASP.NET Core wrapper. I hope the wrappers get fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug C: TreeList FP: Completed Sync status with associated Feedback Item jQuery SEV: Medium
Projects
None yet
Development

No branches or pull requests

5 participants