Follow redirects even when the response was not empty #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
eveliotc
added a commit
that referenced
this pull request
Jul 28, 2013
Follow redirects even when the response was not empty
|
Sorry, my fault, thanks for point me out. But I suggest moving "master" tag to 1.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existance and/or size content length header field is not really indicative of a redirect. The content length header may be empty for a non-redirected request as well as there may be some content returned for a redirected request.
With this PR, only the existance of the location header field is used to determine if the request is being redirected.