fix(core-price-lockup): fixing horizontal alignment issue

[nicmak]

Related issues

#825

Description

• wrapped a div with inline-block and alignment left to account FlexGrid Row horizontal alignment changes

Checklist before submitting pull request

• New code is unit tested
• For code changes, run yarn prepr locally
  • make sure visual and accessibility tests pass

[TDSBot]

Changes:
 - @tds/core-price-lockup: 1.0.1 => 1.0.2


🤔 If this is not what you expected, ensure that your commit messages follow the Conventional Commits specification (https://conventionalcommits.org) and try again.

🚀 Please paste the entire output of this task into the body of your Pull Request so that a maintainer can verify before merging/publishing.

[theetrain]

Thanks for the quick fix! Please address my two comments and I'll get this merged soon.

[theetrain]

This fix can be achieved without display: inline-block

[nicmak]

If i remove inline-block (this is when I include the code inside box component), horizontal alignment does not work from FlexGrid.Row.

[theetrain]

If we release this using inline-block then it will be a breaking change because it would cause subsequent inline elements to appear inline, for example:

<PriceLockup
  size="medium"
  topText="Starting at"
  price="25"
  rateText="/month"
  bottomText="$68 /month after 3 months"
  signDirection="left"
/>
<ButtonLink href="#">Click me</ButtonLink>

We have backlogged a patch to have Price Lockup have a max width, that way the hairline divider's width won't need to be controlled by the developer via FlexGrid: https://telusdigital.atlassian.net/browse/TDS-1042

[theetrain]

Thanks for the update, please address the following:

• Remove inline-block (see comment above)
• Update Jest snapshot and e2e screenshot for the build to pass

[TDSBot]

Changes:
 - @tds/core-breadcrumbs: 1.0.0-dev => 1.0.0
 - @tds/core-checkbox: 1.1.0 => 1.1.1
 - @tds/core-display-heading: 1.0.4 => 1.0.5
 - @tds/core-expand-collapse: 1.2.0 => 1.2.1
 - @tds/core-flex-grid: 2.2.0 => 2.2.1
 - @tds/core-heading: 1.1.3 => 1.1.4
 - @tds/core-input: 1.0.10 => 1.0.11
 - @tds/core-notification: 1.2.0 => 1.2.1
 - @tds/core-ordered-list: 2.0.0 => 2.0.1
 - @tds/core-paragraph: 1.0.2 => 1.0.3
 - @tds/core-price-lockup: 1.0.1 => 1.0.2
 - @tds/core-radio: 1.1.0 => 1.1.1
 - @tds/core-select: 1.0.11 => 1.0.12
 - @tds/core-small: 1.0.2 => 1.0.3
 - @tds/core-spinner: 2.0.2 => 2.0.3
 - @tds/core-step-tracker: 2.0.2 => 2.0.3
 - @tds/core-strong: 1.0.2 => 1.0.3
 - @tds/core-text: 1.0.2 => 1.0.3
 - @tds/core-text-area: 1.0.9 => 1.0.10
 - @tds/core-tooltip: 2.0.2 => 2.0.3
 - @tds/core-unordered-list: 2.0.0 => 2.0.1
 - @tds/shared-choice: 1.0.6 => 1.0.7 (private)
 - @tds/shared-colored-text-provider: 1.0.0-dev => 1.0.0 (private)
 - @tds/shared-form-field: 1.0.7 => 1.0.8 (private)
 - @tds/shared-typography: 1.0.2 => 1.0.3 (private)


🤔 If this is not what you expected, ensure that your commit messages follow the Conventional Commits specification (https://conventionalcommits.org) and try again.

🚀 Please paste the entire output of this task into the body of your Pull Request so that a maintainer can verify before merging/publishing.

[theetrain]

This looks ready for QA 👍

Please wait for Breadcrumbs component to be released before merging. Please squash and merge this PR.