Skip to content

Commit

Permalink
fix(button): add padding to the left and right of every button
Browse files Browse the repository at this point in the history 
🍤
  • Loading branch information
@theetrain
theetrain committed Nov 3, 2017
1 parent 0daf3b9 commit 243e411
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/components/Button/BaseButton/BaseButton.modules.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ $button-text-color: $color-white;
display: block;

width: 100%;
padding: 0 2rem;

cursor: pointer;

Expand Down

3 comments on commit 243e411

@ryanoglesby08
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theetrain. Alfred pinged me on this too. We will need to release another patch to fix the padding.

However, let's use the Box component here instead of the hard coded padding.

@theetrain
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanoglesby08 I considered that at first, but remembered if we use level 5 spacing (32px) it is responsive, and will be 48px on larger viewports. I recommend we hard-code this.

@ryanoglesby08
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhhh I see. Ok gotcha.

Please sign in to comment.