Skip to content

Commit

Permalink
feat(paragraph): Rename the base class as noSpacing to better describ…
Browse files Browse the repository at this point in the history
…e its purpose

Also remove the alignment from it because we have an explicit alignment prop now.
  • Loading branch information
ryanoglesby08 committed Aug 24, 2017
1 parent 14bd906 commit 8782b2d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/components/Typography/Paragraph/Paragraph.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const Paragraph = ({ bold, size, align, invert, children, ...rest }, context) =>
const paragraphColor = invert ? textStyles.colorInverted : textStyles.color

const classes = classnames(
styles.base,
styles.noSpacing,
context.inheritColor ? styles.inheritColor : paragraphColor,
textStyles[size],
bold ? textStyles.boldFont : textStyles[`${size}Font`],
Expand Down
4 changes: 1 addition & 3 deletions src/components/Typography/Paragraph/Paragraph.modules.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
.base {
.noSpacing {
padding: 0;
margin: 0;

text-align: left;
}

.inheritColor {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`Paragraph renders 1`] = `
<p
className="base color medium mediumFont leftAlign"
className="noSpacing color medium mediumFont leftAlign"
>
Some content
</p>
Expand Down

0 comments on commit 8782b2d

Please sign in to comment.