fix(responsive): use defaultmatches for all uses #471
Conversation
- test: add ssr tests for Box, Button, ExpandCollapse, DisplayHeading, Heading, Tooltip - upgrade jest to 22.x - add testid to ExpandCollapse tertiarytext in order to be selectable
| @@ -83,7 +83,7 @@ | |||
| "gitbook-cli": "^2.3.2", | |||
| "husky": "^0.14.3", | |||
| "identity-obj-proxy": "^3.0.0", | |||
| "jest": "^21.2.1", | |||
| "jest": "^22.2.1", | |||
There was a problem hiding this comment.
What an odd coincidence, the latest version of Jest happens to have the same minor and patch version integer. 🍨
|
|
||
| import Box from '../Box' | ||
|
|
||
| describe('responsive behaviour', () => { |
There was a problem hiding this comment.
I think this describe can be a bit more specific so that it will show up properly in the output. The behaviour being tested is also about SSR I believe, not responsiveness.
Perhaps it should be:
describe('Box server side rendering', ...)|
|
||
| import Button from '../Button' | ||
|
|
||
| describe('responsive behaviour', () => { |
There was a problem hiding this comment.
Same comment as Box...
|
|
||
| import ExpandCollapse from '../ExpandCollapse' | ||
|
|
||
| describe('responsive behaviour', () => { |
There was a problem hiding this comment.
Same comment as Box...
| @@ -4,6 +4,7 @@ import { mount, render } from 'enzyme' | |||
| import { warn } from '../../../../utils/warn' | |||
|
|
|||
| import ButtonLink from '../ButtonLink' | |||
| import Responsive from '../../../Responsive/Responsive' | |||
There was a problem hiding this comment.
I don't see a "ButtonLink.ssr.spec.jsx" file..... I think this test should be rewritten to follow the SSR pattern established in the other components.
|
|
||
| import Tooltip from '../Tooltip' | ||
|
|
||
| describe('responsive behaviour', () => { |
There was a problem hiding this comment.
Same comment as Box...
|
|
||
| import DisplayHeading from '../DisplayHeading' | ||
|
|
||
| describe('responsive behaviour', () => { |
There was a problem hiding this comment.
Same comment as Box...
|
|
||
| import Heading from '../Heading' | ||
|
|
||
| describe('responsive behaviour', () => { |
There was a problem hiding this comment.
Same comment as Box...
| it('renders', () => { | ||
| const heading = render(<Heading level="h2">The heading</Heading>) | ||
|
|
||
| expect(heading).toMatchSnapshot() | ||
| }) | ||
|
|
||
| it('renders mobile styles by default', () => { |
There was a problem hiding this comment.
I think since we have a "Heading.ssr.spec.jsx" file, then this test is not necessary.
theetrain
force-pushed
the
fix/TDS-517
branch
from
9a2db22
to
3f24d2d
Compare
|
|
||
| return button | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this doShallow still used? Why was it added if its not used? If it is used, it is called doShallow but it does a mount..... something is awry here.....
|
|
||
| return heading | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this doShallow still used? Why was it added?
* fix(responsive): use defaultmatches for all uses - test: add ssr tests for Box, Button, ExpandCollapse, DisplayHeading, Heading, Tooltip - upgrade jest to 22.x - add testid to ExpandCollapse tertiarytext in order to be selectable * test: adjust server side rendering descriptors * refactor(tests): remove dirty laundry 👕
Description
<Responsive>in their desktop form