Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnings with VS2019 /W3 #25

Closed
manxorist opened this issue May 23, 2021 · 3 comments
Closed

warnings with VS2019 /W3 #25

manxorist opened this issue May 23, 2021 · 3 comments

Comments

@manxorist
Copy link
Contributor

1>ACCADecompressor.cpp
1>API.cpp
1>ARTMDecompressor.cpp
1>BLZWDecompressor.cpp
1>BZIP2Decompressor.cpp
1>CBR0Decompressor.cpp
1>CRMDecompressor.cpp
1>CYB2Decoder.cpp
1>DEFLATEDecompressor.cpp
1>DLTADecode.cpp
1>DMSDecompressor.cpp
1>Decompressor.cpp
1>FASTDecompressor.cpp
1>FBR2Decompressor.cpp
1>FRLEDecompressor.cpp
1>HFMNDecompressor.cpp
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\FBR2Decompressor.cpp(61,11): warning C4146: unary minus operator applied to unsigned type, result still unsigned
1>HUFFDecompressor.cpp
1>ILZRDecompressor.cpp
1>IMPDecompressor.cpp
1>InputStream.cpp
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\ILZRDecompressor.cpp(63,46): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
1>LHLBDecompressor.cpp
1>LIN1Decompressor.cpp
1>LIN2Decompressor.cpp
1>LZBSDecompressor.cpp
1>LZCBDecompressor.cpp
1>LZW2Decompressor.cpp
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\LZBSDecompressor.cpp(66,49): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
1>LZW4Decompressor.cpp
1>LZW5Decompressor.cpp
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\LZCBDecompressor.cpp(279,12): warning C4244: 'initializing': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\LZCBDecompressor.cpp(314,31): warning C4244: '=': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>LZXDecompressor.cpp
1>LH1Decompressor.cpp
1>LH2Decompressor.cpp
1>LH3Decompressor.cpp
1>LHXDecompressor.cpp
1>LZ5Decompressor.cpp
1>LZHDecompressor.cpp
1>LZSDecompressor.cpp
1>PMDecompressor.cpp
1>MASHDecompressor.cpp
1>MMCMPDecompressor.cpp
1>NONEDecompressor.cpp
1>NUKEDecompressor.cpp
1>OutputStream.cpp
1>PPDecompressor.cpp
1>RAKEDecompressor.cpp
1>RDCNDecompressor.cpp
1>RLENDecompressor.cpp
1>RNCDecompressor.cpp
1>RangeDecoder.cpp
1>SDHCDecompressor.cpp
1>SHR3Decompressor.cpp
1>SHRIDecompressor.cpp
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SDHCDecompressor.cpp(75,13): warning C4244: '=': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SDHCDecompressor.cpp(92,13): warning C4244: '=': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SDHCDecompressor.cpp(94,13): warning C4244: '=': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>SLZ3Decompressor.cpp
1>SMPLDecompressor.cpp
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SHRIDecompressor.cpp(48,12): warning C4146: unary minus operator applied to unsigned type, result still unsigned
1>SQSHDecompressor.cpp
1>SXSCDecompressor.cpp
1>StoneCrackerDecompressor.cpp
1>TDCSDecompressor.cpp
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SXSCDecompressor.cpp(200,46): warning C4244: 'argument': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SXSCDecompressor.cpp(203,56): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SXSCDecompressor.cpp(213,115): warning C4267: 'initializing': conversion from 'size_t' to 'uint16_t', possible loss of data
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SXSCDecompressor.cpp(650,27): warning C4244: '=': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SXSCDecompressor.cpp(734,24): warning C4244: '=': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SXSCDecompressor.cpp(746,26): warning C4244: 'argument': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SXSCDecompressor.cpp(751,21): warning C4244: '=': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>TPWMDecompressor.cpp
1>XPKDecompressor.cpp
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\StoneCrackerDecompressor.cpp(181,25): warning C4101: 'e': unreferenced local variable
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\StoneCrackerDecompressor.cpp(520,25): warning C4244: 'argument': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\StoneCrackerDecompressor.cpp(581,41): warning C4244: 'argument': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>XPKMain.cpp
1>ZENODecompressor.cpp
1>ImplodeDecompressor.cpp
1>ReduceDecompressor.cpp
1>ShrinkDecompressor.cpp
1>ZIPDecompressor.cpp
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\Zip\ImplodeDecompressor.cpp(79,41): warning C4018: '>': signed/unsigned mismatch
1>Buffer.cpp
1>CRC16.cpp
1>CRC32.cpp
1>Common.cpp
1>MemoryBuffer.cpp
1>StaticBuffer.cpp
1>SubBuffer.cpp
1>WrappedVectorBuffer.cpp
@manxorist
Copy link
Contributor Author

manxorist commented May 23, 2021

#30 silences the warnings that were definitely harmless.

I left the cases where I was not immediately sure untouched.
The following warnings still remain after this pull request:

1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\LZCBDecompressor.cpp(279,12): warning C4244: 'initializing': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\LZCBDecompressor.cpp(314,31): warning C4244: '=': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SHRIDecompressor.cpp(48,12): warning C4146: unary minus operator applied to unsigned type, result still unsigned
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SXSCDecompressor.cpp(200,46): warning C4244: 'argument': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SXSCDecompressor.cpp(650,27): warning C4244: '=': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SXSCDecompressor.cpp(734,24): warning C4244: '=': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SXSCDecompressor.cpp(746,26): warning C4244: 'argument': conversion from 'uint16_t' to 'uint8_t', possible loss of data
1>C:\Users\manx\projects\openmpt\wc\trunk-8\include\ancient\src\SXSCDecompressor.cpp(751,21): warning C4244: '=': conversion from 'uint16_t' to 'uint8_t', possible loss of data

@temisu
Copy link
Owner

temisu commented May 23, 2021

I'll check as soon as I have need to boot to windows..
(these are harmless)

@temisu
Copy link
Owner

temisu commented Jan 8, 2022

Fixed (finally)

@temisu temisu closed this as completed Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants