Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number confusion between release version and autotools version #37

Closed
manxorist opened this issue Jan 12, 2022 · 5 comments
Closed

Comments

@manxorist
Copy link
Contributor

When I contributed the Autotools build system in #21, I noted that I added version information to configure.ac:

Introduce package versioning (using SemVer) and soname versioning via libtool.
Details are documented at the top of configure.ac.

As the updated API which is incompatible with the older ad-hoc API also went in, I did set the version to 2.0.0-pre, as required by SemVer.

Yet, the update to ancient as a whole you recently released has version 1.1, and the Autotools build system still advertises a pre-release package version 2.0.0-pre.2.

This likely confuses users. I suggest these versions should match and ancient should follow the versioning guidelines that I did add at the top of configure.ac.

Setting the Autotools package version to 2.0.0, and releasing a release versioned also 2.0.0 in a timely fashion should cleanup the situation for now, I think.

I am sorry if I might have caused confusion about the intentions that my versioning changes implied, and I maybe did not communicate the changes properly.

@temisu
Copy link
Owner

temisu commented Jan 12, 2022

I'll try to see tonight if that helps - we can always remove the version if it does not

@temisu
Copy link
Owner

temisu commented Jan 12, 2022

Yeah, I'm no expert on debian builds either and I kind of missed that comment about versions, lets see if this helps

@manxorist
Copy link
Contributor Author

Thanks, The release looks good to me now. Can you also increment LIBANCIENT_LTVER_REVISION (https://github.com/temisu/ancient/blob/master/configure.ac#L20) now, after the release?

@temisu
Copy link
Owner

temisu commented Jan 13, 2022

oops, missed that

@temisu
Copy link
Owner

temisu commented Jan 21, 2022

Looks it is all good now. Closing. Re-open if there are any further issues

@temisu temisu closed this as completed Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants