Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trivial warnings with clang-cl #50

Closed
manxorist opened this issue Jul 19, 2023 · 3 comments
Closed

trivial warnings with clang-cl #50

manxorist opened this issue Jul 19, 2023 · 3 comments

Comments

@manxorist
Copy link
Contributor

src/common/MemoryBuffer.hpp(18,35): warning : class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
src/common/MemoryBuffer.hpp(13,7): note: mark 'ancient::internal::MemoryBuffer' as 'final' to silence this warning

src/common/WrappedVectorBuffer.hpp(20,42): warning : class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
src/common/WrappedVectorBuffer.hpp(16,7): note: mark 'ancient::internal::WrappedVectorBuffer' as 'final' to silence this warning
@temisu
Copy link
Owner

temisu commented Jul 19, 2023

What is the version of the clang-cl, I haven't seen this on apple clang (14)?

Funnily enough, that is fixed in my branch but it is multibroken still (not going to merge it anytime soon). I can pick this thing from there separately

@manxorist
Copy link
Contributor Author

C:\Program Files\Microsoft Visual Studio\2022\Community>clang --version
clang version 15.0.1
Target: i686-pc-windows-msvc
Thread model: posix
InstalledDir: C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\Llvm\bin

@temisu
Copy link
Owner

temisu commented Jul 19, 2023

fixed

@temisu temisu closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants