Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clsx/prefer-objects-over-logical removes quotes when autofixing #6

Open
raphaelbadia opened this issue Mar 9, 2023 · 2 comments
Open

Comments

@raphaelbadia
Copy link

Hello, thank you for this plugin !

I'm trying it today and I found a small bug, when autofixing a condition, eslint-plugin-clsx removes the quotes entirely. I think in this case it should check for quotes and keep them when refactoring >

CleanShot 2023-03-09 at 18 23 01

@temoncher
Copy link
Owner

@raphaelbadia
Yeah looks like a nasty bug! I'm pretty busy lately (as you can see by delay of this answer), I'll fix it when I have time to, no commitments tho

Did you end up disabling this rule or ditching the plugin entirely?

@raphaelbadia
Copy link
Author

I first tried to fix it myself, failed, and ended up ditching the plugin completely because that was the more interesting rule for me and my team. But I'm watching the repo, will know if you happen to fix it 😄 If you don't, no worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants